Skip to content

Conversation

@bbernays
Copy link
Collaborator

@bbernays bbernays commented Jun 19, 2023

Summary

Cannot find any reference or documentation to an ARN for cache policies... Changed the PK from arn to resource id + account id

@github-actions
Copy link

This PR has the following changes to source plugin(s) tables:

  • ⚠️ BREAKING CHANGE: Table aws_cloudfront_cache_policies: column arn removed from table
  • ⚠️ BREAKING CHANGE: Table aws_cloudfront_cache_policies: primary key constraint added to column account_id
  • ⚠️ BREAKING CHANGE: Table aws_cloudfront_cache_policies: primary key constraint added to column id

@disq
Copy link
Member

disq commented Jun 19, 2023

As a side effect this would also break the resources view for this type. Is this a customer issue?

@bbernays
Copy link
Collaborator Author

As a side effect this would also break the resources view for this type. Is this a customer issue?

This is a field we made up so it is not like users would be able to do anything with this field...

@disq
Copy link
Member

disq commented Jun 20, 2023

As a side effect this would also break the resources view for this type. Is this a customer issue?

This is a field we made up so it is not like users would be able to do anything with this field...

Yeah, but if there's no arn column a resource is not listed in the resources view. Granted this is the shortcoming of the resources view (lack of a better formed SQL) I was just wondering if this was an issue with any of our users or a general cleanup of sorts.

@hermanschaaf
Copy link
Member

Even though it's made up, it's still a breaking change to remove it, and like @disq mentioned will cause it to disappear from the resources view, so I think we can leave it in place for now.

@bbernays bbernays closed this Jun 20, 2023
@bbernays bbernays deleted the fix-cf-arn branch July 6, 2023 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants