Skip to content

Conversation

@hermanschaaf
Copy link
Member

@hermanschaaf hermanschaaf commented Jun 19, 2023

Upgrades the PostgreSQL destination to plugin SDK V4. This changes the plugin to use the new streaming interface, allowing migrations to happen more than once during a sync and for PostgreSQL to be used as a state backend.

While there shouldn't be anything breaking in this upgrade, I am marking this as a breaking change because it is a big internal refactor, and despite our best efforts there may be some things that we missed during testing.

@hermanschaaf hermanschaaf marked this pull request as ready for review July 4, 2023 16:08
@hermanschaaf hermanschaaf requested a review from yevgenypats as a code owner July 4, 2023 16:08
@hermanschaaf
Copy link
Member Author

Seems like GitHub is lagging; I pushed a commit to fix the merge conflicts a few minutes ago already but it's not showing up yet.

@hermanschaaf hermanschaaf changed the title feat(postgresql): Migrate Postgres destination to SDK v4 feat(postgresql)!: Migrate Postgres destination to SDK v4 Jul 6, 2023
@yevgenypats yevgenypats added the automerge Automatically merge once required checks pass label Jul 6, 2023
@kodiakhq kodiakhq bot merged commit 186f594 into main Jul 6, 2023
@kodiakhq kodiakhq bot deleted the v4-postgres-destination branch July 6, 2023 11:32
kodiakhq bot pushed a commit that referenced this pull request Jul 6, 2023
🤖 I have created a release *beep* *boop*
---


## [5.0.0](plugins-destination-postgresql-v4.2.2...plugins-destination-postgresql-v5.0.0) (2023-07-06)


### ⚠ BREAKING CHANGES

* **postgresql:** Migrate Postgres destination to SDK v4 ([#11662](#11662))

### Features

* **postgresql:** Migrate Postgres destination to SDK v4 ([#11662](#11662)) ([186f594](186f594))


### Bug Fixes

* **deps:** Update github.com/apache/arrow/go/v13 digest to 5a06b2e ([#11857](#11857)) ([43c2f5f](43c2f5f))
* **deps:** Update github.com/cloudquery/arrow/go/v13 digest to 0656028 ([#11739](#11739)) ([7a6ad49](7a6ad49))
* **deps:** Update github.com/cloudquery/arrow/go/v13 digest to 1e68c51 ([#11637](#11637)) ([46043bc](46043bc))
* **deps:** Update github.com/cloudquery/arrow/go/v13 digest to 43638cb ([#11672](#11672)) ([3c60bbb](3c60bbb))
* **deps:** Update github.com/cloudquery/arrow/go/v13 digest to 4d76231 ([#11532](#11532)) ([6f04233](6f04233))
* **deps:** Update github.com/cloudquery/arrow/go/v13 digest to 8366a22 ([#11717](#11717)) ([8eeff5b](8eeff5b))
* **deps:** Update github.com/cloudquery/arrow/go/v13 digest to 95d3199 ([#11708](#11708)) ([03f214f](03f214f))
* **deps:** Update github.com/cloudquery/arrow/go/v13 digest to b0832be ([#11651](#11651)) ([71e8c29](71e8c29))
* **deps:** Update github.com/cloudquery/arrow/go/v13 digest to d864719 ([#11611](#11611)) ([557a290](557a290))
* **deps:** Update github.com/cloudquery/arrow/go/v13 digest to df3b664 ([#11882](#11882)) ([9635b22](9635b22))
* **deps:** Update github.com/cloudquery/arrow/go/v13 digest to f060192 ([#11730](#11730)) ([c7019c2](c7019c2))
* **deps:** Update github.com/cloudquery/arrow/go/v13 digest to f0dffc6 ([#11689](#11689)) ([18ac0e9](18ac0e9))
* **deps:** Update module github.com/cloudquery/plugin-pb-go to v1.1.0 ([#11665](#11665)) ([d8947c9](d8947c9))
* **deps:** Update module github.com/cloudquery/plugin-pb-go to v1.2.0 ([#11720](#11720)) ([7ef521d](7ef521d))
* **deps:** Update module github.com/cloudquery/plugin-pb-go to v1.2.1 ([#11722](#11722)) ([309be72](309be72))
* **deps:** Update module github.com/cloudquery/plugin-pb-go to v1.3.3 ([#11726](#11726)) ([f0ca611](f0ca611))
* **deps:** Update module github.com/cloudquery/plugin-pb-go to v1.3.4 ([#11753](#11753)) ([cd4fe1c](cd4fe1c))
* **deps:** Update module github.com/cloudquery/plugin-pb-go to v1.5.0 ([#11850](#11850)) ([3255857](3255857))
* **deps:** Update module github.com/cloudquery/plugin-pb-go to v1.6.0 ([#11916](#11916)) ([421e752](421e752))
* **deps:** Update module github.com/cloudquery/plugin-sdk/v3 to v3.10.6 ([#11473](#11473)) ([7272133](7272133))
* **postgresql:** Re run release please ([55e2f71](55e2f71))
* **postgresql:** Rerun release please ([#12002](#12002)) ([9d12843](9d12843))
* **postgresql:** Rerun release please ([#12018](#12018)) ([643755b](643755b))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
kodiakhq bot pushed a commit that referenced this pull request Jul 18, 2023
… not only via `migrate_mode: forced` (#12390)



#### Summary

Fixes #10545.
PostgreSQL was done in #11662 so I used the message from that PR.
I also aligned the logic in DuckDB to print all tables (taken from the MySQL plugin)

<!--
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automerge Automatically merge once required checks pass

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants