feat!: Support number type with precision and scale #11540
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erezrokah
requested review from
a team,
disq and
hermanschaaf
and removed request for
a team and
hermanschaaf
Closed
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #11538. This is a breaking change since now if a
numberhas precision it will create a float type column at the destination.Parsing the precision and scale is take from https://github.com/cloudquery/cloudquery/pull/11115/files#diff-619acf691639d4d0288b58b3814d54d67a93f4774f22d61dc5812348ef099b4c and I'll port the query update from this PR to #11115
BEGIN_COMMIT_OVERRIDE
feat: Support number type with precision and scale
BREAKING-CHANGE: Support for parsing
numbertype precision and scale was added. As a result number columns with scale that is different than0, e.g.number(6,2)will be converted tofloattype at the destination instead ofint. You might need to either run with forced migration mode or migrate the destination manually.END_COMMIT_OVERRIDE