fix(sqlite): Escape PK constraint name #11478
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erezrokah
requested review from
a team and
candiduslynx
and removed request for
a team
erezrokah
commented
Jun 13, 2023
| sb.WriteString(", CONSTRAINT ") | ||
| sb.WriteString(table.Name) | ||
| sb.WriteString("_cqpk PRIMARY KEY (") | ||
| sb.WriteString(identifier(table.Name + "_cqpk")) |
candiduslynx
approved these changes
Jun 13, 2023
kodiakhq bot
pushed a commit
that referenced
this pull request
Jun 13, 2023
🤖 I have created a release *beep* *boop* --- ## [2.2.2](plugins-destination-sqlite-v2.2.1...plugins-destination-sqlite-v2.2.2) (2023-06-13) ### Bug Fixes * **deps:** Update github.com/cloudquery/arrow/go/v13 digest to 0f7bd3b ([#11412](#11412)) ([dd1e2e8](dd1e2e8)) * **deps:** Update github.com/cloudquery/arrow/go/v13 digest to 7f6aaff ([#11432](#11432)) ([55dfebc](55dfebc)) * **deps:** Update github.com/cloudquery/arrow/go/v13 digest to 8f72077 ([#11395](#11395)) ([d91fc5c](d91fc5c)) * **deps:** Update github.com/cloudquery/arrow/go/v13 digest to 90670b8 ([#11279](#11279)) ([a6cdc91](a6cdc91)) * **deps:** Update github.com/cloudquery/arrow/go/v13 digest to b359e74 ([#11405](#11405)) ([5d92765](5d92765)) * **deps:** Update github.com/cloudquery/arrow/go/v13 digest to d8eacf8 ([#11449](#11449)) ([742dafd](742dafd)) * **deps:** Update github.com/cloudquery/arrow/go/v13 digest to e258cfb ([#11391](#11391)) ([eacbe9a](eacbe9a)) * **sqlite:** Escape PK constraint name ([#11478](#11478)) ([9ea9c79](9ea9c79)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Noticed this while working on the Firestore source. Looks like we were escaping everything but the constraint name.