fix(aws)!: Move web_acl_arn to its own table
#11421
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR has the following changes to source plugin(s) tables:
|
disq
approved these changes
Jun 12, 2023
hermanschaaf
approved these changes
Jun 12, 2023
|
|
||
| https://docs.aws.amazon.com/waf/latest/APIReference/API_GetWebACLForResource.html | ||
|
|
||
| The primary key for this table is **_cq_id**. |
Member
There was a problem hiding this comment.
Any primary key we could be using here?
Collaborator
Author
There was a problem hiding this comment.
updated to use load_balancer_arn,arn
hermanschaaf
approved these changes
Jun 12, 2023
kodiakhq bot
pushed a commit
that referenced
this pull request
Jun 20, 2023
🤖 I have created a release *beep* *boop* --- ## [19.0.0](plugins-source-aws-v18.4.0...plugins-source-aws-v19.0.0) (2023-06-20) ### ⚠ BREAKING CHANGES * **aws:** Move `web_acl_arn` to its own table ([#11421](#11421)) * **aws:** Add support For fully describing the organizational hierarchy ([#11633](#11633)) * **aws:** Support all policy types in Identity Center ([#10985](#10985)) ### This Release has the Following Changes to Tables - Table `aws_cloudfront_functions` was added - Table `aws_cloudfront_origin_access_identities` was added - Table `aws_cloudfront_origin_request_policies` was added - Table `aws_cloudfront_response_headers_policies` was added - Table `aws_cloudtrail_channels` was added - Table `aws_cloudtrail_imports` was added - Table `aws_ec2_capacity_reservations` was added - Table `aws_elbv2_load_balancer_web_acls` was added - Table `aws_elbv2_load_balancers`: column `web_acl_arn` removed from table (:warning: breaking) - Table `aws_organizations_account_parents` was added - Table `aws_organizations_organizational_unit_parents` was added - Table `aws_organizations_organizational_units`: column `account_id` removed from table (:warning: breaking) - Table `aws_organizations_organizational_units`: column added with name `request_account_id (PK)` and type `utf8` (:warning: breaking) - Table `aws_s3_buckets`: column added with name `policy_status` and type `json` - Table `aws_ssoadmin_account_assignments` was removed (:warning: breaking) - Table `aws_ssoadmin_instances`: primary key constraint added to column `instance_arn` (:warning: breaking) - Table `aws_ssoadmin_instances`: primary key constraint removed from column `_cq_id` (:warning: breaking) - Table `aws_ssoadmin_permission_set_account_assignments` was added - Table `aws_ssoadmin_permission_set_customer_managed_policies` was added - Table `aws_ssoadmin_permission_set_inline_policies` was added - Table `aws_ssoadmin_permission_set_managed_policies` was added - Table `aws_ssoadmin_permission_set_permissions_boundaries` was added - Table `aws_ssoadmin_permission_sets`: column `inline_policy` removed from table (:warning: breaking) - Table `aws_ssoadmin_permission_sets`: column added with name `instance_arn (PK)` and type `utf8` (:warning: breaking) - Table `aws_ssoadmin_permission_sets`: primary key constraint added to column `permission_set_arn` (:warning: breaking) - Table `aws_ssoadmin_permission_sets`: primary key constraint removed from column `_cq_id` (:warning: breaking) ### Features * **aws-services:** Support newly added regions ([#11673](#11673)) ([8c0ab9d](8c0ab9d)) * **aws:** Add PolicyStatus to WrappedBucket ([#11657](#11657)) ([55d966a](55d966a)) * **aws:** Add support for Cloudfront Functions ([#11669](#11669)) ([102067a](102067a)) * **aws:** Add Support for Cloudtrail Channels ([#11670](#11670)) ([0dc13de](0dc13de)) * **aws:** Add Support for Cloudtrail Imports ([#11671](#11671)) ([c908289](c908289)) * **aws:** Add support for EC2 Capacity Reservations ([#11666](#11666)) ([70d6052](70d6052)) * **aws:** Add support For fully describing the organizational hierarchy ([#11633](#11633)) ([f66995b](f66995b)) * **aws:** Add Support for more Cloudfront Resources ([#11668](#11668)) ([52e6ad9](52e6ad9)) * **aws:** Support all policy types in Identity Center ([#10985](#10985)) ([a8ab255](a8ab255)) ### Bug Fixes * **aws:** Move `web_acl_arn` to its own table ([#11421](#11421)) ([cdda682](cdda682)) * **deps:** Update github.com/cloudquery/arrow/go/v13 digest to 1e68c51 ([#11637](#11637)) ([46043bc](46043bc)) * **deps:** Update github.com/cloudquery/arrow/go/v13 digest to 43638cb ([#11672](#11672)) ([3c60bbb](3c60bbb)) * **deps:** Update github.com/cloudquery/arrow/go/v13 digest to b0832be ([#11651](#11651)) ([71e8c29](71e8c29)) * **deps:** Update module github.com/aws/aws-sdk-go-v2 to v1.18.1 ([#11652](#11652)) ([4230b52](4230b52)) * **deps:** Update module github.com/aws/aws-sdk-go-v2/config to v1.18.27 ([#11653](#11653)) ([4b45408](4b45408)) * **deps:** Update module github.com/cloudquery/plugin-pb-go to v1.1.0 ([#11665](#11665)) ([d8947c9](d8947c9)) * Use ServiceAccountRegion multiplexer for aws_availability_zones ([#11686](#11686)) ([7f4788f](7f4788f)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Moves
web_acl_arncolumn to its own table and removes the old column #11419If we want to do this in a backwards compatible way we could look into doing that as well, but I didn't go through that effort until we decided which path to go down