feat(azure): Add option to normalize ID values to be all lowercase #11388
Conversation
erezrokah
left a comment
erezrokah
left a comment
There was a problem hiding this comment.
Can we make this optional via configuration so it's not a breaking change?
If it works well we can make it the default.
Also maybe there's a way to hook into the Azure SDK and handle it here? The team is quite responsive so we can ask via an issue here https://github.com/Azure/azure-sdk-for-go/issues
done
Asked, I don't think they'll recommend anything other than a custom |
disq
changed the title
| return nil | ||
| } | ||
|
|
||
| func ChainRowResolvers(next ...schema.RowResolver) schema.RowResolver { |
There was a problem hiding this comment.
This is currently unused and may be removed.
disq
changed the title
Follow-up to #11388. We don't want `SetItem()`, we want to `Set()` the column directly. Opening as `chore` because the fix is unreleased.
🤖 I have created a release *beep* *boop* --- ## [8.2.0](plugins-source-azure-v8.1.0...plugins-source-azure-v8.2.0) (2023-06-13) ### Features * **azure:** Add option to normalize ID values to be all lowercase ([#11388](#11388)) ([82134ee](82134ee)), closes [#10779](#10779) ### Bug Fixes * **deps:** Update github.com/cloudquery/arrow/go/v13 digest to 0f7bd3b ([#11412](#11412)) ([dd1e2e8](dd1e2e8)) * **deps:** Update github.com/cloudquery/arrow/go/v13 digest to 7f6aaff ([#11432](#11432)) ([55dfebc](55dfebc)) * **deps:** Update github.com/cloudquery/arrow/go/v13 digest to 8f72077 ([#11395](#11395)) ([d91fc5c](d91fc5c)) * **deps:** Update github.com/cloudquery/arrow/go/v13 digest to 90670b8 ([#11279](#11279)) ([a6cdc91](a6cdc91)) * **deps:** Update github.com/cloudquery/arrow/go/v13 digest to b359e74 ([#11405](#11405)) ([5d92765](5d92765)) * **deps:** Update github.com/cloudquery/arrow/go/v13 digest to d8eacf8 ([#11449](#11449)) ([742dafd](742dafd)) * **deps:** Update github.com/cloudquery/arrow/go/v13 digest to e258cfb ([#11391](#11391)) ([eacbe9a](eacbe9a)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
3 participants
Just a draft. I don't like the untestability of this as its current state (with injected PostResourceResolvers).Fixed in c61aec5Fixes #10779