fix(azure): Fix some CIS Azure policies #11228
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
June 6, 2023 14:52
aruneko
changed the title
yevgenypats
approved these changes
Jun 6, 2023
hermanschaaf
changed the title
Member
|
/gen sha=b48d18fa7177a2462618ae5cd840ed7cd7192ff5 plugin=azure |
kodiakhq bot
pushed a commit
that referenced
this pull request
Jun 6, 2023
🤖 I have created a release *beep* *boop* --- ## [8.1.0](plugins-source-azure-v8.0.0...plugins-source-azure-v8.1.0) (2023-06-06) ### Features * **azure-resources:** Add DNS Record Sets ([#10918](#10918)) ([7c56926](7c56926)) * **azure:** Add CIS 1.21, 6.3, 6.4, 8.5 policies ([#11194](#11194)) ([a3cda9b](a3cda9b)) * **azure:** Implement missing CIS policies ([#10928](#10928)) ([3ae3df3](3ae3df3)) ### Bug Fixes * **azure:** Consumption legacy usage details ([#11242](#11242)) ([8da78c6](8da78c6)) * **azure:** Fix some CIS Azure policies ([#11228](#11228)) ([b95a4df](b95a4df)) * **deps:** Update github.com/apache/arrow/go/v13 digest to e07e22c ([#11151](#11151)) ([5083cf7](5083cf7)) * **deps:** Update github.com/cloudquery/arrow/go/v13 digest to 20b0de9 ([#11199](#11199)) ([dc3565d](dc3565d)) * **deps:** Update github.com/cloudquery/arrow/go/v13 digest to 88d5dc2 ([#11226](#11226)) ([9f306bc](9f306bc)) * **deps:** Update github.com/cloudquery/arrow/go/v13 digest to a7aad4c ([#11184](#11184)) ([8a0822e](8a0822e)) * **deps:** Update github.com/cloudquery/arrow/go/v13 digest to c67fb39 ([#11169](#11169)) ([dcb0f92](dcb0f92)) * **deps:** Update golang.org/x/exp digest to 2e198f4 ([#11155](#11155)) ([c46c62b](c46c62b)) * **deps:** Update google.golang.org/genproto digest to e85fd2c ([#11156](#11156)) ([dbe7e92](dbe7e92)) * **deps:** Update module github.com/cloudquery/plugin-pb-go to v1.0.9 ([#11240](#11240)) ([f92cd4b](f92cd4b)) * **deps:** Update module github.com/cloudquery/plugin-sdk/v3 to v3.10.3 ([#11150](#11150)) ([dc00994](dc00994)) * **deps:** Update module github.com/cloudquery/plugin-sdk/v3 to v3.10.4 ([#11244](#11244)) ([8fceef6](8fceef6)) * **deps:** Update module github.com/cloudquery/plugin-sdk/v3 to v3.7.0 ([#11113](#11113)) ([487bf87](487bf87)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Section 1.21
I have misunderstood the condition of CIS Azure Section 1.21.
It should be checked for only custom roles.
And I forgot to put
INSERTquery in this SQL file...Section 4.1.1
The join condition on from query has been fixed for actual relationship.
Section 4.1.2
According to the CIS benchmark documentation, they say below.
So, we have to exclude
masterdatabase from results.