feat(nested): Simplify constructing nested ClickHouse value #11205
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
candiduslynx
force-pushed
the
feat/simplify-sanitize-nested
branch
2 times, most recently
from
83095d0 to
20ce29e
Compare
candiduslynx
requested review from
a team and
disq
and removed request for
a team
candiduslynx
force-pushed
the
feat/simplify-sanitize-nested
branch
from
20ce29e to
cec1e14
Compare
erezrokah
approved these changes
Jun 5, 2023
Member
|
Just one comment, what makes this a |
Contributor
Author
It changes a bit how the empty struct value is passed to the database (basically, the |
kodiakhq bot
pushed a commit
that referenced
this pull request
Jun 6, 2023
🤖 I have created a release *beep* *boop* --- ## [3.2.0](plugins-destination-clickhouse-v3.1.1...plugins-destination-clickhouse-v3.2.0) (2023-06-06) ### Features * **nested:** Simplify constructing nested ClickHouse value ([#11205](#11205)) ([dd6b275](dd6b275)) ### Bug Fixes * **deps:** Update `github.com/cloudquery/plugin-sdk/v3` to `v3.8.1` ([#11078](#11078)) ([0a1764f](0a1764f)) * **deps:** Update github.com/apache/arrow/go/v13 digest to e07e22c ([#11151](#11151)) ([5083cf7](5083cf7)) * **deps:** Update github.com/cloudquery/arrow/go/v13 digest to 20b0de9 ([#11199](#11199)) ([dc3565d](dc3565d)) * **deps:** Update github.com/cloudquery/arrow/go/v13 digest to 88d5dc2 ([#11226](#11226)) ([9f306bc](9f306bc)) * **deps:** Update github.com/cloudquery/arrow/go/v13 digest to a7aad4c ([#11184](#11184)) ([8a0822e](8a0822e)) * **deps:** Update github.com/cloudquery/arrow/go/v13 digest to c67fb39 ([#11169](#11169)) ([dcb0f92](dcb0f92)) * **deps:** Update golang.org/x/exp digest to 2e198f4 ([#11155](#11155)) ([c46c62b](c46c62b)) * **deps:** Update google.golang.org/genproto digest to e85fd2c ([#11156](#11156)) ([dbe7e92](dbe7e92)) * **deps:** Update module github.com/cloudquery/plugin-pb-go to v1.0.9 ([#11240](#11240)) ([f92cd4b](f92cd4b)) * **deps:** Update module github.com/cloudquery/plugin-sdk/v3 to v3.10.4 ([#11244](#11244)) ([8fceef6](8fceef6)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires cloudquery/plugin-sdk#948
Benchmarks
Performed by the following command in
typeconv/ch/valuesdir:go test \ -test.run=BenchmarkFromArray \ -test.bench=BenchmarkFromArray \ -test.count 10 -test.benchmem -test.benchtime 10000xBefore this update
After this update