chore(refactor): Refactor DuckDB #11188
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
candiduslynx
requested review from
a team,
disq and
yevgenypats
and removed request for
a team
candiduslynx
force-pushed
the
chore/duckdb/refactor
branch
from
43c8770 to
75394b9
Compare
candiduslynx
force-pushed
the
chore/duckdb/refactor
branch
from
75394b9 to
bd87f34
Compare
erezrokah
reviewed
Jun 2, 2023
Member
erezrokah
left a comment
erezrokah
left a comment
There was a problem hiding this comment.
This looks good, thanks for breaking the refactoring to a separate PR.
I have one question though
erezrokah
approved these changes
Jun 2, 2023
disq
approved these changes
Jun 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted from #11116 (pt2)