Skip to content

Conversation

@candiduslynx
Copy link
Contributor

@candiduslynx candiduslynx commented May 29, 2023

@candiduslynx candiduslynx requested review from a team and yevgenypats May 29, 2023 07:59
@candiduslynx candiduslynx changed the title fix(deps): Update github.com/cloudquery/plugin-sdk/v3 to v3.8.0 fix(deps): Update github.com/cloudquery/plugin-sdk/v3 to v3.7.0 May 30, 2023
@candiduslynx candiduslynx force-pushed the fix/ch/sdk-bump branch 2 times, most recently from 2cf00aa to d5b7b01 Compare May 30, 2023 12:59
zeroshade pushed a commit to apache/arrow that referenced this pull request May 31, 2023
…roxEqual` (#35823)

### Rationale for this change

If we store the value of the `*array.Map` into Go map we can't expect to put the values back in the same order, as the map traversal order in Go is undefined.
This PR extends `array.ApproxEqual` by allowing map keys to be in different order.

### What changes are included in this PR?

New helper functions:
* `array.arrayApproxEqualMap` that is now used instead of `array.arrayApproxEqualList` for map comparison
* `array.arrayApproxEqualSingleMapEntry` that checks if the single map entry we have matches to the other one without having keys sorted the same way

### Are these changes tested?

1. Newly added test `array.TestArrayApproxEqualMaps`
2. cloudquery/cloudquery#11078

### Are there any user-facing changes?

New `array.WithUnorderedMapKeys` option for `array.ApproxEqual` that allows users to control if the entries order is important or not.

* Closes: #35828

Authored-by: candiduslynx <[email protected]>
Signed-off-by: Matt Topol <[email protected]>
kodiakhq bot pushed a commit to cloudquery/plugin-sdk that referenced this pull request Jun 1, 2023
@candiduslynx candiduslynx changed the title fix(deps): Update github.com/cloudquery/plugin-sdk/v3 to v3.7.0 fix(deps): Update github.com/cloudquery/plugin-sdk/v3 to v3.8.1 Jun 1, 2023
@candiduslynx candiduslynx added the automerge Automatically merge once required checks pass label Jun 1, 2023
Copy link
Member

@erezrokah erezrokah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @candiduslynx, I did a first pass and mostly have questions on the some of the changes to ensure I understand everything correctly.

@candiduslynx candiduslynx requested a review from erezrokah June 1, 2023 09:08
@kodiakhq kodiakhq bot merged commit 0a1764f into main Jun 1, 2023
@kodiakhq kodiakhq bot deleted the fix/ch/sdk-bump branch June 1, 2023 13:47
kodiakhq bot pushed a commit that referenced this pull request Jun 6, 2023
🤖 I have created a release *beep* *boop*
---


## [3.2.0](plugins-destination-clickhouse-v3.1.1...plugins-destination-clickhouse-v3.2.0) (2023-06-06)


### Features

* **nested:** Simplify constructing nested ClickHouse value ([#11205](#11205)) ([dd6b275](dd6b275))


### Bug Fixes

* **deps:** Update `github.com/cloudquery/plugin-sdk/v3` to `v3.8.1` ([#11078](#11078)) ([0a1764f](0a1764f))
* **deps:** Update github.com/apache/arrow/go/v13 digest to e07e22c ([#11151](#11151)) ([5083cf7](5083cf7))
* **deps:** Update github.com/cloudquery/arrow/go/v13 digest to 20b0de9 ([#11199](#11199)) ([dc3565d](dc3565d))
* **deps:** Update github.com/cloudquery/arrow/go/v13 digest to 88d5dc2 ([#11226](#11226)) ([9f306bc](9f306bc))
* **deps:** Update github.com/cloudquery/arrow/go/v13 digest to a7aad4c ([#11184](#11184)) ([8a0822e](8a0822e))
* **deps:** Update github.com/cloudquery/arrow/go/v13 digest to c67fb39 ([#11169](#11169)) ([dcb0f92](dcb0f92))
* **deps:** Update golang.org/x/exp digest to 2e198f4 ([#11155](#11155)) ([c46c62b](c46c62b))
* **deps:** Update google.golang.org/genproto digest to e85fd2c ([#11156](#11156)) ([dbe7e92](dbe7e92))
* **deps:** Update module github.com/cloudquery/plugin-pb-go to v1.0.9 ([#11240](#11240)) ([f92cd4b](f92cd4b))
* **deps:** Update module github.com/cloudquery/plugin-sdk/v3 to v3.10.4 ([#11244](#11244)) ([8fceef6](8fceef6))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
kou pushed a commit to apache/arrow-go that referenced this pull request Aug 30, 2024
…roxEqual` (#35823)

### Rationale for this change

If we store the value of the `*array.Map` into Go map we can't expect to put the values back in the same order, as the map traversal order in Go is undefined.
This PR extends `array.ApproxEqual` by allowing map keys to be in different order.

### What changes are included in this PR?

New helper functions:
* `array.arrayApproxEqualMap` that is now used instead of `array.arrayApproxEqualList` for map comparison
* `array.arrayApproxEqualSingleMapEntry` that checks if the single map entry we have matches to the other one without having keys sorted the same way

### Are these changes tested?

1. Newly added test `array.TestArrayApproxEqualMaps`
2. cloudquery/cloudquery#11078

### Are there any user-facing changes?

New `array.WithUnorderedMapKeys` option for `array.ApproxEqual` that allows users to control if the entries order is important or not.

* Closes: #35828

Authored-by: candiduslynx <[email protected]>
Signed-off-by: Matt Topol <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automerge Automatically merge once required checks pass

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants