feat(kafka): Update to github.com/cloudquery/plugin-sdk/v3 #10902
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbernays
requested review from
a team and
hermanschaaf
and removed request for
a team
Contributor
candiduslynx
left a comment
candiduslynx
left a comment
There was a problem hiding this comment.
It's OK, but shouldn't it also update the filetypes?
This reverts commit ddbec57.
Collaborator
Author
There seem to be issues in V3 of the filetypes library surrounding parquet implementation. So as soon as that is resolved we can update the library... In the mean time at least this destination will be able to be used with Arrow sources |
candiduslynx
approved these changes
May 23, 2023
bbernays
added
automerge
kodiakhq bot
pushed a commit
that referenced
this pull request
Jun 1, 2023
🤖 I have created a release *beep* *boop* --- ## [3.1.0](plugins-destination-kafka-v3.0.1...plugins-destination-kafka-v3.1.0) (2023-06-01) ### Features * **deps:** Upgrade to Apache Arrow v13 (latest `cqmain`) ([#10605](#10605)) ([a55da3d](a55da3d)) * **kafka:** Update to github.com/cloudquery/plugin-sdk/v3 ([#10902](#10902)) ([ba96208](ba96208)), closes [#10721](#10721) * **kafka:** Upgrade to v3 ([#10931](#10931)) ([400e0e4](400e0e4)) * Update to `github.com/cloudquery/filetypes/v3` `v3.1.0` ([#10942](#10942)) ([40ca741](40ca741)) ### Bug Fixes * **deps:** Update github.com/apache/arrow/go/v13 digest to e07e22c ([#11151](#11151)) ([5083cf7](5083cf7)) * **deps:** Update google.golang.org/genproto digest to e85fd2c ([#11156](#11156)) ([dbe7e92](dbe7e92)) * **deps:** Update module github.com/cloudquery/plugin-pb-go to v1.0.8 ([#10798](#10798)) ([27ff430](27ff430)) * **deps:** Update module github.com/cloudquery/plugin-sdk/v3 to v3.6.7 ([#11043](#11043)) ([3c6d885](3c6d885)) * **deps:** Update module github.com/cloudquery/plugin-sdk/v3 to v3.7.0 ([#11113](#11113)) ([487bf87](487bf87)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
closes #10721