feat(okta): Add rate limiter config #10880
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
candiduslynx
requested review from
a team and
yevgenypats
and removed request for
a team
candiduslynx
commented
May 22, 2023
candiduslynx
force-pushed
the
feat/okta/rl
branch
from
81117df to
71318e0
Compare
candiduslynx
force-pushed
the
feat/okta/rl
branch
from
71318e0 to
704759f
Compare
| return fmt.Errorf("missing API token (should be set in the configuration or as %q environment variable)", OktaAPIToken) | ||
| } | ||
|
|
||
| const exampleDomain = "https://<CHANGE_THIS_TO_YOUR_OKTA_DOMAIN>.okta.com" |
Member
There was a problem hiding this comment.
I don't think we really need to handle this specific case, we can just check for empty. But if we do handle this case, the example on the website right now is YOUR_OKTA_DOMAIN, not CHANGE_THIS_TO_YOUR_OKTA_DOMAIN
| func (s *Spec) setDefaults() { | ||
| const ( | ||
| minRetries = int32(3) | ||
| minBackOff = 5 * time.Second |
Member
There was a problem hiding this comment.
Looks like the default is 30s with 2 retries (based on a quick google finding this: https://github.com/okta/okta-sdk-golang/blob/master/okta/okta.go#L187); if users were already running into errors before we should probably keep the default backOff to 30s or so as well (the minimum can still be less)
disq
approved these changes
May 22, 2023
Member
|
Foiled by automerge, sorry |
kodiakhq bot
pushed a commit
that referenced
this pull request
May 22, 2023
🤖 I have created a release *beep* *boop* --- ## [2.4.0](plugins-source-okta-v2.3.1...plugins-source-okta-v2.4.0) (2023-05-22) ### This Release has the Following Changes to Tables - Table `okta_application_users`: column order changed for `id` - Table `okta_applications`: column order changed for `id` - Table `okta_groups`: column order changed for `id` - Table `okta_users`: column order changed for `id` ### Features * **deps:** Upgrade to Apache Arrow v13 (latest `cqmain`) ([#10605](#10605)) ([a55da3d](a55da3d)) * **okta:** Add rate limiter config ([#10880](#10880)) ([293d9d0](293d9d0)), closes [#10570](#10570) * **okta:** Enable SDK Debug Logs ([#10889](#10889)) ([4004bc9](4004bc9)) ### Bug Fixes * **deps:** Update module github.com/cloudquery/plugin-pb-go to v1.0.8 ([#10798](#10798)) ([27ff430](27ff430)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #10570