feat(gremlin): Add complete_types option
#10846
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
disq
commented
May 18, 2023
disq
changed the title
neptune_compatibility optioncomplete_types option
candiduslynx
approved these changes
May 18, 2023
Contributor
candiduslynx
left a comment
candiduslynx
left a comment
There was a problem hiding this comment.
only 1 nit, otherwise good
Co-authored-by: Alex Shcherbakov <[email protected]>
candiduslynx
approved these changes
May 18, 2023
kodiakhq bot
pushed a commit
that referenced
this pull request
May 18, 2023
🤖 I have created a release *beep* *boop* --- ## [2.1.0](plugins-destination-gremlin-v2.0.2...plugins-destination-gremlin-v2.1.0) (2023-05-18) ### Features * **deps:** Upgrade to Apache Arrow v13 (latest `cqmain`) ([#10605](#10605)) ([a55da3d](a55da3d)) * **gremlin:** Add `complete_types` option ([#10846](#10846)) ([43166e1](43166e1)), closes [#10839](#10839) * **gremlin:** Upgrade to SDK v3 ([#10821](#10821)) ([27fc337](27fc337)) ### Bug Fixes * **deps:** Update module github.com/aws/aws-sdk-go-v2/config to v1.18.25 ([#10786](#10786)) ([caca1a4](caca1a4)) * **deps:** Update module github.com/cloudquery/plugin-pb-go to v1.0.8 ([#10798](#10798)) ([27ff430](27ff430)) * **gremlin:** Upgrade gremlingo to official 3.6.3 ([#10824](#10824)) ([656f2a2](656f2a2)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Neptune doesn't support list types (among other things) so we need to represent lists as strings.
The option defaults to
false(assuming we have more Neptune users than Apache TinkerPop users it was worded as such)Fixes #10839