feat(snowflake): Migrate to SDK V3 native arrow #10822
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
disq
reviewed
May 16, 2023
| make test | ||
| ``` | ||
|
|
||
| https://REMBAZX.ZO72963.europe-west4.gcp.snowflakecomputing.com:443/session/v1/login-request?databaseName=testdb&requestId=e8d15dca-cd82-4995-77a1-c0dffc4f1a68&request_guid=36aac0a0-0221-4bd4-7108-fb0227f17bcc&schemaName=public&warehouse=test |
yevgenypats
force-pushed
the
feat/snowflake_sdkv3
branch
from
5862d89 to
08ac076
Compare
candiduslynx
suggested changes
May 16, 2023
| u, err := strconv.ParseInt(val.(string), 10, 8) | ||
| if err != nil { | ||
| return err | ||
| return fmt.Errorf("failed to parse int8: %w", err) |
Contributor
There was a problem hiding this comment.
I'd just go with AppendValueFromString everywhere
| b.Append(val.([]uint8)) | ||
| case *array.TimestampBuilder: | ||
| b.Append(arrow.Timestamp(val.(time.Time).UnixMicro())) | ||
| var timeVal time.Time |
Contributor
There was a problem hiding this comment.
Contributor
Author
There was a problem hiding this comment.
not sure I understand this comment.
Contributor
There was a problem hiding this comment.
Instead of parsing manually you could use arrow.TimestampFromString(val.(string), b.Type().(*arrow.TimestampType).Unit
| default: | ||
| return fmt.Errorf("unsupported timestamp unit %s", f.Type.(*arrow.TimestampType).Unit) | ||
| } | ||
| case array.ListLikeBuilder: |
Contributor
Author
There was a problem hiding this comment.
Im not sure how from string will work here given it's time.Time
Contributor
Author
There was a problem hiding this comment.
basically we need to add to arrow AppendTime but for now not to block it we can just use this.
Co-authored-by: Alex Shcherbakov <[email protected]>
Co-authored-by: Alex Shcherbakov <[email protected]>
kodiakhq bot
pushed a commit
that referenced
this pull request
May 18, 2023
🤖 I have created a release *beep* *boop* --- ## [2.1.0](plugins-destination-snowflake-v2.0.3...plugins-destination-snowflake-v2.1.0) (2023-05-18) ### Features * **deps:** Upgrade to Apache Arrow v13 (latest `cqmain`) ([#10605](#10605)) ([a55da3d](a55da3d)) * **snowflake:** Migrate to SDK V3 native arrow ([#10822](#10822)) ([9b5dfe0](9b5dfe0)) ### Bug Fixes * **deps:** Update module github.com/aws/aws-sdk-go-v2/credentials to v1.13.24 ([#10787](#10787)) ([2056241](2056241)) * **deps:** Update module github.com/aws/aws-sdk-go-v2/feature/s3/manager to v1.11.67 ([#10788](#10788)) ([fd660b2](fd660b2)) * **deps:** Update module github.com/cloudquery/plugin-pb-go to v1.0.8 ([#10798](#10798)) ([27ff430](27ff430)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #10729