feat(s3): Add support for custom S3 endpoint #10589
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hermanschaaf
requested changes
May 8, 2023
Member
hermanschaaf
left a comment
hermanschaaf
left a comment
There was a problem hiding this comment.
The change looks good, but missing documentation (I don't think AWS_S3_ENDPOINT is a standard AWS environment variable?)
candiduslynx
suggested changes
May 8, 2023
hermanschaaf
approved these changes
May 8, 2023
candiduslynx
approved these changes
May 8, 2023
bbernays
previously requested changes
May 8, 2023
hermanschaaf
reviewed
May 9, 2023
|
|
||
| - `endpoint` (string) (optional, default empty) | ||
|
|
||
| Endpoint to use for S3 API calls. This is useful for S3-compatible storage services such as MinIO. |
Member
There was a problem hiding this comment.
Maybe we can include an example that shows how to use this in conjunction with an AWS_S3_ENDPOINT environment variable (we can do this in a follow-up)
Member
Author
There was a problem hiding this comment.
@hermanschaaf What do you mean, there's no AWS_S3_ENDPOINT env var any more?
Member
There was a problem hiding this comment.
Sorry yeah I mean, if a user was set on using an environment variable called AWS_S3_ENDPOINT (like I think the user who requested this was), then they can still do so by doing:
endpoint: "${AWS_S3_ENDPOINT}"
which I think is worth pointing out in the docs
hermanschaaf
approved these changes
May 9, 2023
candiduslynx
approved these changes
May 9, 2023
candiduslynx
changed the title
candiduslynx
changed the title
candiduslynx
added
automerge
kodiakhq bot
pushed a commit
that referenced
this pull request
May 9, 2023
🤖 I have created a release *beep* *boop* --- ## [4.2.0](plugins-destination-s3-v4.1.0...plugins-destination-s3-v4.2.0) (2023-05-09) ### Features * **s3:** Add support for custom S3 endpoint ([#10589](#10589)) ([48c6379](48c6379)) ### Bug Fixes * **deps:** Update module github.com/aws/aws-sdk-go-v2/config to v1.18.23 ([#10576](#10576)) ([eeb13d5](eeb13d5)) * **deps:** Update module github.com/aws/aws-sdk-go-v2/feature/s3/manager to v1.11.65 ([#10582](#10582)) ([4ed90e3](4ed90e3)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9739
The doc for the SDK feature is here https://aws.github.io/aws-sdk-go-v2/docs/configuring-sdk/endpoints/