feat: Add AWS Config Compliance Details table #10544
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR has the following changes to source plugin(s) tables:
|
Closed
hermanschaaf
commented
May 2, 2023
|
|
||
| input := &configservice.DescribeRetentionConfigurationsInput{} | ||
| p := configservice.NewDescribeRetentionConfigurationsPaginator(svc, input) | ||
| p := configservice.NewDescribeRetentionConfigurationsPaginator(svc, nil) |
Member
Author
There was a problem hiding this comment.
Just a bit of clean-up requested in a previous PR; no functional changes
hermanschaaf
commented
May 3, 2023
| Resolver: schema.ParentColumnResolver("config_rule_name"), | ||
| }, | ||
| { | ||
| Name: "_evaluation_hash", |
Member
Author
There was a problem hiding this comment.
I'm not sure this is the best way to go; we could also not have a PK at all and have it default to _cq_id. Thoughts on this?
Member
There was a problem hiding this comment.
Defaulting to _cq_id could be better because if the user wants deterministic they can set deterministic_cq_id in the spec and have the _cq_id generated from all column values automatically. On the other hand that setting affects all tables.
Member
Author
There was a problem hiding this comment.
Yeah exactly, deterministic_cq_id affects all tables which is probably not what users would want. We do use this ResolveObjectHash technique in two other places as well, but I think that predated deterministic_cq_id. What do you think - just use _cq_id?
Member
There was a problem hiding this comment.
I'm unsure but yes the ResolveObjectHash method predates deterministic_cq_id so it's probably better to just keep it simple.
disq
reviewed
May 3, 2023
plugins/source/aws/resources/services/config/config_rule_compliance_details.go
Outdated
Show resolved
Hide resolved
…iance_details.go Co-authored-by: Kemal <[email protected]>
Member
Author
|
/gen sha=0e5a3d36b7a87bb77fa454f063e2707f7743e4a7 plugin=aws |
…/cloudquery into aws-config-compliance-details
disq
approved these changes
May 3, 2023
hermanschaaf
added
automerge
kodiakhq bot
pushed a commit
that referenced
this pull request
May 16, 2023
🤖 I have created a release *beep* *boop* --- ## [17.3.0](plugins-source-aws-v17.2.0...plugins-source-aws-v17.3.0) (2023-05-16) ### This Release has the Following Changes to Tables - Table `aws_acmpca_certificate_authorities` was added - Table `aws_cloudformation_stack_templates` was added - Table `aws_cloudformation_template_summaries` was added - Table `aws_config_config_rule_compliance_details` was added - Table `aws_efs_access_points` was added ### Features * Add AWS Config Compliance Details table ([#10544](#10544)) ([9b43a2a](9b43a2a)) * Add Cloudformation Template Summaries table ([#10571](#10571)) ([3515db9](3515db9)) * **aws-services:** Support newly added regions ([#10806](#10806)) ([52b5e0f](52b5e0f)) * **aws:** Add private certificate authorities ([#10691](#10691)) ([9c97e85](9c97e85)) * **aws:** Add Support for Cloudformation Templates ([#10701](#10701)) ([7a23c2e](7a23c2e)) * **aws:** Add support for EFS Access Point ([#10803](#10803)) ([d994c85](d994c85)) * **aws:** Support Table level inputs ([#10564](#10564)) ([161b11b](161b11b)) * **deps:** Upgrade to Apache Arrow v13 (latest `cqmain`) ([#10605](#10605)) ([a55da3d](a55da3d)) ### Bug Fixes * **aws-policies:** Api Gateway stage logging for REST ([#10625](#10625)) ([f0d6f57](f0d6f57)) * **aws-policies:** Api Gateway stage logging for websockets ([#10702](#10702)) ([e667400](e667400)) * **aws:** Change column type of `aws_cloudformation_stack_templates.template_body` ([#10752](#10752)) ([75b9785](75b9785)) * **aws:** Fix the case where resrouce_id is null in ECS.2 of foundational policy ([#10692](#10692)) ([f5cf2d8](f5cf2d8)) * **aws:** Handle Cloudfront Regions in different partitions ([#10690](#10690)) ([158aab1](158aab1)) * **deps:** Update module github.com/aws/aws-sdk-go-v2/config to v1.18.25 ([#10786](#10786)) ([caca1a4](caca1a4)) * **deps:** Update module github.com/aws/aws-sdk-go-v2/service/acm to v1.17.11 ([#10789](#10789)) ([9122f84](9122f84)) * **deps:** Update module github.com/aws/aws-sdk-go-v2/service/amp to v1.16.11 ([#10790](#10790)) ([431905f](431905f)) * **deps:** Update module github.com/aws/aws-sdk-go-v2/service/amplify to v1.13.10 ([#10791](#10791)) ([81d175b](81d175b)) * **deps:** Update module github.com/cloudquery/plugin-pb-go to v1.0.8 ([#10798](#10798)) ([27ff430](27ff430)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an
aws_config_config_rule_compliance_detailstable, requested by a user in the thread on #7711 (comment).This table allows you to get evaluation results for resources discovered through AWS config rule evaluations, which you can then query together with other CloudQuery resources.