feat: More AWS Config resources #10509
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR has the following changes to source plugin(s) tables:
|
disq
approved these changes
May 2, 2023
disq
reviewed
May 2, 2023
| svc := c.Services().Configservice | ||
|
|
||
| input := &configservice.DescribeRetentionConfigurationsInput{} | ||
| p := configservice.NewDescribeRetentionConfigurationsPaginator(svc, input) |
Member
There was a problem hiding this comment.
This can also be:
Suggested change
| p := configservice.NewDescribeRetentionConfigurationsPaginator(svc, input) | |
| p := configservice.NewDescribeRetentionConfigurationsPaginator(svc, nil) |
Member
Author
There was a problem hiding this comment.
Thanks, I will fix this in a likely follow-up to add one more resource type
hermanschaaf
added
automerge
kodiakhq bot
pushed a commit
that referenced
this pull request
May 9, 2023
🤖 I have created a release *beep* *boop* --- ## [17.2.0](plugins-source-aws-v17.1.0...plugins-source-aws-v17.2.0) (2023-05-09) ### This Release has the Following Changes to Tables - Table `aws_config_configuration_aggregators` was added - Table `aws_config_remediation_configurations` was added - Table `aws_config_retention_configurations` was added - Table `aws_networkfirewall_firewall_policies` was added - Table `aws_networkfirewall_rule_groups` was added - Table `aws_securityhub_enabled_standards` was added - Table `aws_securityhub_hubs` was added - Table `aws_wafregional_rule_groups`: column added with name `rule_ids` and type `StringArray` ### Features * **aws-services:** Support newly added regions ([#10598](#10598)) ([e56bae2](e56bae2)) * **aws:** Add `aws_securityhub_hubs` and `aws_securityhub_enabled_standards` tables ([#10553](#10553)) ([bc77f53](bc77f53)), closes [#1592](#1592) * **aws:** Add networkfirewall resources ([#10547](#10547)) ([74ada09](74ada09)) * **aws:** Add rule_ids to wafregional rule_group ([#10594](#10594)) ([4637baa](4637baa)) * **aws:** Refine AWS Org Error Message ([#10569](#10569)) ([b761ebc](b761ebc)) * More AWS Config resources ([#10509](#10509)) ([3db4ebb](3db4ebb)) ### Bug Fixes * **aws-policies:** Api Gateway xray tracing enabled query ([#10597](#10597)) ([341d849](341d849)) * **aws:** Use GetBucketLocation for S3 bucket region ([#10550](#10550)) ([7f0128f](7f0128f)), closes [#10548](#10548) * **deps:** Update module github.com/aws/aws-sdk-go-v2/config to v1.18.23 ([#10576](#10576)) ([eeb13d5](eeb13d5)) * **deps:** Update module github.com/aws/aws-sdk-go-v2/internal/v4a to v1.0.25 ([#10585](#10585)) ([00d7449](00d7449)) * **deps:** Update module github.com/aws/aws-sdk-go-v2/service/accessanalyzer to v1.19.12 ([#10586](#10586)) ([4f929fe](4f929fe)) * Remove unused line in mockassert library ([#10608](#10608)) ([3fc8708](3fc8708)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds Retention Configuration, Configuration Aggregators, Remediation Configurations.
Closes #7711