feat(mssql)!: Upgrade to github.com/cloudquery/plugin-sdk/v2
#10506
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
candiduslynx
requested review from
erezrokah,
hermanschaaf and
yevgenypats
as code owners
Closed
hermanschaaf
requested changes
May 2, 2023
Member
hermanschaaf
left a comment
hermanschaaf
left a comment
There was a problem hiding this comment.
Looks great, just a couple of comments
candiduslynx
force-pushed
the
feat/plugin-sdk-v2/mssql
branch
from
9821047 to
e9ac92f
Compare
candiduslynx
force-pushed
the
feat/plugin-sdk-v2/mssql
branch
from
e9ac92f to
f371cbb
Compare
candiduslynx
force-pushed
the
feat/plugin-sdk-v2/mssql
branch
from
ce6382a to
3e80131
Compare
candiduslynx
force-pushed
the
feat/plugin-sdk-v2/mssql
branch
from
3e80131 to
5333a93
Compare
hermanschaaf
approved these changes
May 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #9848
BEGIN_COMMIT_OVERRIDE
feat: Update to use Apache Arrow type system
BREAKING-CHANGE: This release introduces an internal change to our type system to use Apache Arrow. This should not have any visible breaking changes, however due to the size of the change we are introducing it under a major version bump to communicate that it might have some bugs that we weren't able to catch during our internal tests. If you encounter an issue during the upgrade, please submit a bug report.
END_COMMIT_OVERRIDE