-
Notifications
You must be signed in to change notification settings - Fork 547
feat(hubspot): Add properties support on hubspot source plugin #10376
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
kodiakhq
merged 11 commits into
cloudquery:main
from
fsschmitt:feat/add-properties-to-hubspot-source
Apr 28, 2023
Merged
feat(hubspot): Add properties support on hubspot source plugin #10376
kodiakhq
merged 11 commits into
cloudquery:main
from
fsschmitt:feat/add-properties-to-hubspot-source
Apr 28, 2023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@fsschmitt Thanks for this contribution! will review this shortly! |
candiduslynx
suggested changes
Apr 28, 2023
Co-authored-by: candiduslynx <[email protected]>
candiduslynx
suggested changes
Apr 28, 2023
Co-authored-by: candiduslynx <[email protected]>
candiduslynx
approved these changes
Apr 28, 2023
yevgenypats
approved these changes
Apr 28, 2023
kodiakhq bot
pushed a commit
that referenced
this pull request
May 2, 2023
🤖 I have created a release *beep* *boop* --- ## [1.4.0](plugins-source-hubspot-v1.3.0...plugins-source-hubspot-v1.4.0) (2023-05-02) ### Features * **hubspot:** Add properties support on hubspot source plugin ([#10376](#10376)) ([d5520a1](d5520a1)) ### Bug Fixes * **deps:** Update github.com/apache/arrow/go/v12 digest to 0ea1a10 ([#10461](#10461)) ([022709f](022709f)) * **deps:** Update module github.com/cloudquery/plugin-sdk/v2 to v2.5.0 ([#10390](#10390)) ([f706688](f706688)) * **deps:** Update module github.com/cloudquery/plugin-sdk/v2 to v2.5.1 ([#10448](#10448)) ([cc85b93](cc85b93)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #10373
The goal of this PR is to add support for properties when capturing information from HubSpot, this enables users to specify the properties for each entity that they want to retrieve.
This mimics the behaviour of HubSpot API, where the user needs to pass as a query parameter the properties that it wants to be returned on the API call.
This will enable users to add the properties for each entity that they want to be extracted using cloud query, as up until now, only the "core properties" were being collected:
Before
A company would only return the core properties:
After
The cloudquery user can specify the additional properties to be extracted, such as:
response: