Skip to content

Conversation

@fsschmitt
Copy link
Contributor

Summary

Closes #10373

The goal of this PR is to add support for properties when capturing information from HubSpot, this enables users to specify the properties for each entity that they want to retrieve.

This mimics the behaviour of HubSpot API, where the user needs to pass as a query parameter the properties that it wants to be returned on the API call.

This will enable users to add the properties for each entity that they want to be extracted using cloud query, as up until now, only the "core properties" were being collected:

Before

A company would only return the core properties:

"properties": {
  "createdate": "2023-04-13T09:07:29.661Z",
  "domain": null,
  "hs_lastmodifieddate": "2023-04-13T09:08:14.185Z",
  "hs_object_id": "6316510341",
  "name": "John Doe Corp"
}

After

The cloudquery user can specify the additional properties to be extracted, such as:

spec:
  companies:
    properties: ["hs_lead_status"]

response:

"properties": {
  "createdate": "2023-04-13T09:07:29.661Z",
  "domain": null,
  "hs_lastmodifieddate": "2023-04-13T09:08:14.185Z",
  "hs_object_id": "6316510341",
  "hs_lead_status": "cold",
  "name": "John Doe Corp"
}

@fsschmitt fsschmitt requested review from a team and bbernays and removed request for a team April 26, 2023 19:22
@fsschmitt fsschmitt changed the title feat: add properties support on hubspot source plugin feat(hubspot): add properties support on hubspot source plugin Apr 26, 2023
@fsschmitt fsschmitt changed the title feat(hubspot): add properties support on hubspot source plugin feat(hubspot): Add properties support on hubspot source plugin Apr 26, 2023
@yevgenypats yevgenypats requested review from yevgenypats and removed request for bbernays April 27, 2023 09:19
@yevgenypats
Copy link
Contributor

@fsschmitt Thanks for this contribution! will review this shortly!

@yevgenypats yevgenypats added the automerge Automatically merge once required checks pass label Apr 28, 2023
@kodiakhq kodiakhq bot merged commit d5520a1 into cloudquery:main Apr 28, 2023
kodiakhq bot pushed a commit that referenced this pull request May 2, 2023
🤖 I have created a release *beep* *boop*
---


## [1.4.0](plugins-source-hubspot-v1.3.0...plugins-source-hubspot-v1.4.0) (2023-05-02)


### Features

* **hubspot:** Add properties support on hubspot source plugin ([#10376](#10376)) ([d5520a1](d5520a1))


### Bug Fixes

* **deps:** Update github.com/apache/arrow/go/v12 digest to 0ea1a10 ([#10461](#10461)) ([022709f](022709f))
* **deps:** Update module github.com/cloudquery/plugin-sdk/v2 to v2.5.0 ([#10390](#10390)) ([f706688](f706688))
* **deps:** Update module github.com/cloudquery/plugin-sdk/v2 to v2.5.1 ([#10448](#10448)) ([cc85b93](cc85b93))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automerge Automatically merge once required checks pass

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat: Add properties spec to hubspot source plugin

4 participants