feat(resources): Use resourcemanager/resources/armsubscriptions for subscription resources
#10369
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR has the following changes to source plugin(s) tables:
|
disq
commented
Apr 26, 2023
| return &schema.Table{ | ||
| Name: "azure_subscription_subscription_locations", | ||
| Resolver: fetchLocations, | ||
| Description: "https://learn.microsoft.com/en-us/rest/api/resources/subscriptions/list-locations?tabs=HTTP#location", |
Member
Author
There was a problem hiding this comment.
Docs were already pointing to the right API responses so no change was made there.
disq
commented
Apr 26, 2023
| |metadata|JSON| | ||
| |display_name|String| | ||
| |id (PK)|String| | ||
| |latitude|String| |
Member
Author
There was a problem hiding this comment.
This is now a key under metadata along with longitude and bunch of new keys.
Member
There was a problem hiding this comment.
Maybe we can keep these fields as aliases of the ones in the metadata JSON (using path resolver) to keep this change backwards-compatible?
Contributor
There was a problem hiding this comment.
Maybe we can keep these fields as aliases of the ones in the metadata JSON (using path resolver) to keep this change backwards-compatible?
+1
Member
There was a problem hiding this comment.
This looks good, but +1 for making this backwards compatible
Contributor
|
IDK if we want to go through with this breaking change. @yevgenypats what's your take? |
disq
force-pushed
the
feat/azure_rm
branch
4 times, most recently
from
bbedf09 to
b82804b
Compare
…s for subscription resources
disq
changed the title
hermanschaaf
approved these changes
Jun 15, 2023
candiduslynx
approved these changes
Jun 15, 2023
candiduslynx
changed the title
resourcemanager/resources/armsubscriptions for subscription resources
candiduslynx
changed the title
resourcemanager/resources/armsubscriptions for subscription resourcesresourcemanager/resources/armsubscriptions for subscription resources
erezrokah
approved these changes
Jun 15, 2023
erezrokah
pushed a commit
that referenced
this pull request
Jun 20, 2023
🤖 I have created a release *beep* *boop* --- ## [8.3.0](plugins-source-azure-v8.2.0...plugins-source-azure-v8.3.0) (2023-06-20) ### This Release has the Following Changes to Tables - Table `azure_cognitiveservices_account_deployments` was added - Table `azure_cognitiveservices_account_models` was added - Table `azure_cognitiveservices_account_private_endpoint_connections` was added - Table `azure_cognitiveservices_account_private_link_resources` was added - Table `azure_cognitiveservices_account_skus` was added - Table `azure_cognitiveservices_account_usages` was added - Table `azure_cognitiveservices_commitment_plans` was added - Table `azure_cognitiveservices_resource_skus` was added - Table `azure_subscription_subscription_locations`: column added with name `metadata` and type `json` - Table `azure_subscription_subscription_locations`: column added with name `regional_display_name` and type `utf8` - Table `azure_subscription_subscription_locations`: column added with name `type` and type `utf8` - Table `azure_subscription_subscriptions`: column added with name `managed_by_tenants` and type `json` - Table `azure_subscription_subscriptions`: column added with name `tags` and type `json` - Table `azure_subscription_subscriptions`: column added with name `tenant_id` and type `utf8` - Table `azure_subscription_tenants`: column added with name `country_code` and type `utf8` - Table `azure_subscription_tenants`: column added with name `country` and type `utf8` - Table `azure_subscription_tenants`: column added with name `default_domain` and type `utf8` - Table `azure_subscription_tenants`: column added with name `display_name` and type `utf8` - Table `azure_subscription_tenants`: column added with name `domains` and type `list<item: utf8, nullable>` - Table `azure_subscription_tenants`: column added with name `tenant_branding_logo_url` and type `utf8` - Table `azure_subscription_tenants`: column added with name `tenant_category` and type `utf8` - Table `azure_subscription_tenants`: column added with name `tenant_type` and type `utf8` ### Features * **azure-resources:** Add missing Cognitive Services resources ([#11645](#11645)) ([74b64e4](74b64e4)) * **resources:** Use `resourcemanager/resources/armsubscriptions` for subscription resources ([#10369](#10369)) ([0a76536](0a76536)), closes [#9854](#9854) ### Bug Fixes * **azure-policies:** Fix Syntax for policies ([#10184](#10184)) ([7795b37](7795b37)) * **deps:** Update github.com/cloudquery/arrow/go/v13 digest to 1e68c51 ([#11637](#11637)) ([46043bc](46043bc)) * **deps:** Update github.com/cloudquery/arrow/go/v13 digest to 4d76231 ([#11532](#11532)) ([6f04233](6f04233)) * **deps:** Update github.com/cloudquery/arrow/go/v13 digest to b0832be ([#11651](#11651)) ([71e8c29](71e8c29)) * **deps:** Update github.com/cloudquery/arrow/go/v13 digest to d864719 ([#11611](#11611)) ([557a290](557a290)) * **deps:** Update module github.com/cloudquery/plugin-sdk/v3 to v3.10.6 ([#11473](#11473)) ([7272133](7272133)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: cq-bot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9854