fix: Update to SDK v2.3.7, remove release calls #10209
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erezrokah
requested review from
a team and
hermanschaaf
and removed request for
a team
erezrokah
commented
Apr 20, 2023
| } | ||
|
|
||
| func reverseTransform(table *arrow.Schema, values []any) (arrow.Record, error) { | ||
| recordBuilder := array.NewRecordBuilder(memory.DefaultAllocator, table) |
Member
Author
There was a problem hiding this comment.
The default allocator is the Go one, so I don't think we need a release here
erezrokah
changed the title
candiduslynx
approved these changes
Apr 20, 2023
yevgenypats
suggested changes
Apr 20, 2023
|
|
||
| func reverseTransform(table *arrow.Schema, values []any) (arrow.Record, error) { | ||
| recordBuilder := array.NewRecordBuilder(memory.DefaultAllocator, table) | ||
| defer recordBuilder.Release() |
Contributor
There was a problem hiding this comment.
I think here it's fine just because the builder is only used in this function scope. we can later try and test if it has any effect on memory vs not using it.
Member
Author
There was a problem hiding this comment.
The default allocator is the Go one so I thought this is a no op. I can keep it if needed but removed to avoid confusion for someone who's later reading the code
Member
There was a problem hiding this comment.
Unfortunately Release is not a no-op in the Go allocator. But I think it's fine to remove it here and let the garbage collector clean it up for the sake of consistency.
Member
Author
There was a problem hiding this comment.
I'm good either way. I worried that using Release might leak into other places in the code if we use it here.
But I don't feel strongly about it.
I pushed a commit to add it back e5e1f6d
Member
Author
There was a problem hiding this comment.
Reverted the commit until we reach a conclusion
erezrokah
force-pushed
the
fix/remove_release_retain_mysql
branch
from
e5e1f6d to
64589fe
Compare
erezrokah
force-pushed
the
fix/remove_release_retain_mysql
branch
from
4e608a0 to
17c5a6c
Compare
yevgenypats
approved these changes
Apr 20, 2023
kodiakhq bot
pushed a commit
that referenced
this pull request
Apr 20, 2023
🤖 I have created a release *beep* *boop* --- ## [2.0.0](plugins-destination-mysql-v1.0.5...plugins-destination-mysql-v2.0.0) (2023-04-20) ### ⚠ BREAKING CHANGES * This release introduces an internal change to our type system to use [Apache Arrow](https://arrow.apache.org/). This should not have any visible breaking changes, however due to the size of the change we are introducing it under a major version bump to communicate that it might have some bugs that we weren't able to catch during our internal tests. If you encounter an issue during the upgrade, please submit a [bug report](https://github.com/cloudquery/cloudquery/issues/new/choose). * Timestamp fields type changed from `datetime` to `datetime(6)` to avoid losing fractional data * Mac Address and Inet column type changed from `nvarchar(255)` to `text` as we cannot assume `nvarchar(255)` columns represent valid Mac Address or Inet * Float fields type changed from `float` to `double` for increased precision ### Features * Float fields type changed from `float` to `double` for increased precision ([c5d3508](c5d3508)) * Mac Address and Inet column type changed from `nvarchar(255)` to `text` as we cannot assume `nvarchar(255)` columns represent valid Mac Address or Inet ([c5d3508](c5d3508)) * Timestamp fields type changed from `datetime` to `datetime(6)` to avoid losing fractional data ([c5d3508](c5d3508)) * Update to plugin SDK v2 ([c5d3508](c5d3508)) * Update to use [Apache Arrow](https://arrow.apache.org/) type system ([c5d3508](c5d3508)) ### Bug Fixes * **deps:** Update module github.com/cloudquery/plugin-sdk to v1.45.0 ([#9863](#9863)) ([2799d62](2799d62)) * **deps:** Update module github.com/cloudquery/plugin-sdk/v2 to v2.3.6 ([#10208](#10208)) ([91c80a7](91c80a7)) * Update to SDK v2.3.7, remove release calls ([#10209](#10209)) ([5442837](5442837)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Follow up to cloudquery/plugin-sdk#810