feat(mongodb)!: Upgrade to SDK V2 (Arrow support) #10194
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yevgenypats
requested review from
a team and
amanenk
and removed request for
a team
yevgenypats
requested review from
disq,
erezrokah and
hermanschaaf
and removed request for
amanenk and
hermanschaaf
disq
reviewed
Apr 19, 2023
disq
reviewed
Apr 19, 2023
Co-authored-by: Kemal <[email protected]>
Co-authored-by: Kemal <[email protected]>
| start, end := a.ValueOffsets(i) | ||
| nested := array.NewSlice(a.ListValues(), start, end) | ||
| dbArr[i] = transformArr(nested) | ||
| nested.Release() |
Member
There was a problem hiding this comment.
Nit: can probably removed now if we're relying on the Go garbage collector
disq
approved these changes
Apr 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is ready apart from a small issue with the microseconds comparison.
Closes #10109
BEGIN_COMMIT_OVERRIDE
feat: Update to use Apache Arrow type system
BREAKING-CHANGE: This release introduces an internal change to our type system to use Apache Arrow. This should not have any visible breaking changes, however due to the size of the change we are introducing it under a major version bump to communicate that it might have some bugs that we weren't able to catch during our internal tests. If you encounter an issue during the upgrade, please submit a bug report.
END_COMMIT_OVERRIDE