Skip to content

feat(docs): Update docs to reflect tables as a required configuration #10189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kodiakhq merged 5 commits into from
Apr 20, 2023
Merged

feat(docs): Update docs to reflect tables as a required configuration #10189

kodiakhq merged 5 commits into from
Apr 20, 2023

Conversation

@erezrokah
Copy link
Member

@erezrokah erezrokah commented Apr 19, 2023 •
edited
Loading

Summary

Part of #9946.
Should be merged after #9864 is released as a major version bump

To find the places to update I searched for kind: source (with/without single/double quotes) in our docs and chose the most suitable default for the use case. I might be missing some context so probably got some wrong

@cq-bot cq-bot added the website label Apr 19, 2023
This was referenced Apr 19, 2023
Closed
Merged
@yevgenypats
Copy link
Contributor

yevgenypats commented Apr 20, 2023

🚀

hermanschaaf
hermanschaaf approved these changes Apr 20, 2023
View reviewed changes
Copy link
Member

@hermanschaaf hermanschaaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 💯

@erezrokah erezrokah added the automerge Automatically merge once required checks pass label Apr 20, 2023
@kodiakhq kodiakhq bot merged commit 6e030f5 into cloudquery:main Apr 20, 2023
@erezrokah erezrokah deleted the feat/website_default_tables_empty branch April 20, 2023 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hermanschaaf hermanschaaf hermanschaaf approved these changes

@bbernays bbernays Awaiting requested review from bbernays

+1 more reviewer

@yevgenypats yevgenypats yevgenypats approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

automerge Automatically merge once required checks pass

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@erezrokah @yevgenypats @hermanschaaf @cq-bot