fix!: Upgrade S3 plugin-sdk and filetypes to v2 #10167
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
hermanschaaf
requested review from
a team and
yevgenypats
and removed request for
a team
disq
reviewed
Apr 20, 2023
| tableName := schema.TableName(arrowSchema) | ||
| if !c.pluginSpec.NoRotate { | ||
| return fmt.Errorf("reading is not supported when no_rotate is false. Table: %q; Source: %q", table.Name, sourceName) | ||
| return fmt.Errorf("reading is not supported when no_rotate is false. Table: %q; Source: %q", tableName, sourceName) |
Member
There was a problem hiding this comment.
More backticks? Although I just noticed these errors are in Read which is only used by the tests
hermanschaaf
changed the title
yevgenypats
suggested changes
Apr 20, 2023
Contributor
yevgenypats
left a comment
yevgenypats
left a comment
There was a problem hiding this comment.
Looks good. few comments.
candiduslynx
suggested changes
Apr 20, 2023
candiduslynx
approved these changes
Apr 20, 2023
Contributor
candiduslynx
left a comment
candiduslynx
left a comment
There was a problem hiding this comment.
a small refactor for loop (nit)
yevgenypats
approved these changes
Apr 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #10112
BEGIN_COMMIT_OVERRIDE
feat: Update to use Apache Arrow type system
BREAKING-CHANGE: This release introduces an internal change to our type system to use Apache Arrow. This should not have any visible breaking changes for CSV or JSON output formats, however the Parquet output changes for UUID columns, which now have dashes, and timestamps, which now uses the default Arrow time format (e.g.
2023-01-02 12:23:45). If you encounter an issue during the upgrade, please submit a bug report.END_COMMIT_OVERRIDE