feat(oracledb): Upgrade to github.com/cloudquery/plugin-sdk/v2
#10166
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
candiduslynx
force-pushed
the
feat/oracledb/plugin-sdk-v2
branch
2 times, most recently
from
bd859c2 to
4a13f7c
Compare
candiduslynx
force-pushed
the
feat/oracledb/plugin-sdk-v2
branch
from
4a13f7c to
bff6490
Compare
yevgenypats
suggested changes
Apr 19, 2023
| return v.String() | ||
| } | ||
|
|
||
| func (*Transformer) RecordToCQTypes(table *schema.Table, record arrow.Record) (schema.CQTypes, error) { |
Contributor
There was a problem hiding this comment.
Can we just bring back the old GenData for this? this will make the migration simpler for now. once we migrate sources to arrow this would also be gone.
Contributor
Author
There was a problem hiding this comment.
kodiakhq bot
pushed a commit
to cloudquery/plugin-sdk
that referenced
this pull request
Apr 19, 2023
yevgenypats
approved these changes
Apr 20, 2023
erezrokah
reviewed
Apr 20, 2023
| builder.WriteString("CREATE TABLE ") | ||
| builder.WriteString(client.Identifier(table.Name)) | ||
| builder.WriteString(" (\n ") | ||
| pk := make([]string, 0, len(table.PrimaryKeys())) |
Member
There was a problem hiding this comment.
Do we still need this change if we use the old test data code?
Contributor
Author
There was a problem hiding this comment.
Yes (as the gendata will gen the row data, but we still have the new table schema with multiple PK columns)
Member
There was a problem hiding this comment.
Update after syncing on Slack. This is needed since we still use a new version of the schema that has multiple PK support
erezrokah
added a commit
that referenced
this pull request
Apr 25, 2023
🤖 I have created a release *beep* *boop* --- ## [1.1.0](plugins-source-oracledb-v1.0.0...plugins-source-oracledb-v1.1.0) (2023-04-25) ### Features * **oracledb:** Upgrade to `github.com/cloudquery/plugin-sdk/v2` ([#10166](#10166)) ([96ed31e](96ed31e)), closes [#10165](#10165) ### Bug Fixes * **deps:** Update module github.com/cloudquery/plugin-sdk/v2 to v2.3.8 ([#10213](#10213)) ([f358666](f358666)) * **deps:** Update module github.com/cloudquery/plugin-sdk/v2 to v2.4.0 ([#10278](#10278)) ([a0a713e](a0a713e)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: Erez Rokah <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #10165