feat(snowflake)!: Update to SDK V2 (Arrow Support) #10161
Conversation
yevgenypats
requested review from
a team and
disq
and removed request for
a team
erezrokah
left a comment
erezrokah
left a comment
There was a problem hiding this comment.
The code looks good, had 2 comments
| return nil, err | ||
| } | ||
| db, err := sql.Open("snowflake", spec.ConnectionString) | ||
| binaryFormat := "BASE64" |
There was a problem hiding this comment.
This seems like an additional breaking change? Can we add it to the change log as well? See example #10169 for multiple breaking changes in a single PR
There was a problem hiding this comment.
This seems like an additional breaking change? Can we add it to the change log as well? See example #10169 for multiple breaking changes in a single PR
@erezrokah I think this is about how Arrow encodes binary columns.
There was a problem hiding this comment.
It's not really a breaking change because it's an encoding for the session only i.e for the arrow/json format when we insert.
There was a problem hiding this comment.
Cool, I thought this impacts the format of the data saved in the DB https://docs.snowflake.com/en/user-guide/binary-input-output#base64
Closes #10113
BEGIN_COMMIT_OVERRIDE
feat: Update to use Apache Arrow type system
BREAKING-CHANGE: This release introduces an internal change to our type system to use Apache Arrow. This should not have any visible breaking changes, however due to the size of the change we are introducing it under a major version bump to communicate that it might have some bugs that we weren't able to catch during our internal tests. If you encounter an issue during the upgrade, please submit a bug report.
END_COMMIT_OVERRIDE