fix(sqlite): Always release records #10154
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yevgenypats
suggested changes
Apr 18, 2023
Contributor
yevgenypats
left a comment
yevgenypats
left a comment
There was a problem hiding this comment.
That's not quite the correct solution. as this will explode in memory. it should be called inside the for loop.
Contributor
Author
@yevgenypats |
hermanschaaf
approved these changes
Apr 18, 2023
yevgenypats
suggested changes
Apr 18, 2023
Contributor
yevgenypats
left a comment
yevgenypats
left a comment
There was a problem hiding this comment.
I don't think line 20 is needed. the channel is not a buffered channel and it's just adds un-necessary logic unless Im missing something.
yevgenypats
approved these changes
Apr 18, 2023
kodiakhq bot
pushed a commit
that referenced
this pull request
Apr 19, 2023
🤖 I have created a release *beep* *boop* --- ## [2.0.1](plugins-destination-sqlite-v2.0.0...plugins-destination-sqlite-v2.0.1) (2023-04-18) ### Bug Fixes * **deps:** Update module github.com/cloudquery/plugin-sdk/v2 to v2.3.0 ([#10163](#10163)) ([9a7f214](9a7f214)) * **deps:** Update module github.com/cloudquery/plugin-sdk/v2 to v2.3.1 ([#10175](#10175)) ([5b53423](5b53423)) * **sqlite:** Always release records ([#10154](#10154)) ([9fb86b9](9fb86b9)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up for #10144