fix: Return error instead of panicking #10147
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Could even wrap with |
yevgenypats
approved these changes
Apr 17, 2023
Contributor
I think it's an error that shouldn't occur rather then not-implemented. That's why I used panic but ret error is also good. I think also |
kodiakhq bot
pushed a commit
that referenced
this pull request
Apr 18, 2023
🤖 I have created a release *beep* *boop* --- ## [4.0.0](plugins-destination-postgresql-v3.0.3...plugins-destination-postgresql-v4.0.0) (2023-04-18) ### ⚠ BREAKING CHANGES * This release introduces an internal change to our type system to use [Apache Arrow](https://arrow.apache.org/). This should not have any visible breaking changes, however due to the size of the change we are introducing it under a major version bump to communicate that it might have some bugs that we weren't able to catch during our internal tests. If you encounter an issue during the upgrade, please submit a [bug report](https://github.com/cloudquery/cloudquery/issues/new/choose). ### Features * Update to use arrow type system ([69dc113](69dc113)) ### Bug Fixes * **deps:** Update module github.com/cloudquery/plugin-sdk to v1.45.0 ([#9863](#9863)) ([2799d62](2799d62)) * Return error instead of panicking ([#10147](#10147)) ([2c0bbeb](2c0bbeb)) * Sanitize constraint name during migrate and write ([#10137](#10137)) ([b58b76c](b58b76c)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The function returns an error so we could do that instead of panicking (unless there's a specific reason to panic I'm missing)