fix(services): Update GCP Services #10133
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![kodiakhq[bot]](https://avatars.githubusercontent.com/in/29196?s=60&v=4){kind=small}
erezrokah
requested changes
Apr 17, 2023
Member
There was a problem hiding this comment.
OK so I think we should look into this as we are extracting cloudiot data, see https://github.com/cloudquery/cloudquery/tree/eefbad516aff7599ab67dedb03d41b0dbb94b88c/plugins/source/gcp/resources/services/cloudiot.
Probably related to this service being deprecated soon https://cloud.google.com/iot-core. We might want to remove the relevant tables
Member
|
I added CloudIOT to the non discoverable services to unblock for now 2874fc8, as it seems the API still works |
erezrokah
approved these changes
Apr 20, 2023
kodiakhq bot
pushed a commit
that referenced
this pull request
Apr 25, 2023
🤖 I have created a release *beep* *boop* --- ## [8.5.0](plugins-source-gcp-v8.4.5...plugins-source-gcp-v8.5.0) (2023-04-25) ### Features * **gcp:** Update GCP Instance Shielded VM Policy ([#10185](#10185)) ([813910d](813910d)) * **gcp:** Upgrade to `github.com/cloudquery/plugin-sdk/v2` ([#9945](#9945)) ([48aadd1](48aadd1)), closes [#9944](#9944) ### Bug Fixes * **deps:** Update module github.com/cloudquery/plugin-sdk/v2 to v2.2.0 ([#10135](#10135)) ([cf33b89](cf33b89)) * **deps:** Update module github.com/cloudquery/plugin-sdk/v2 to v2.2.2 ([#10143](#10143)) ([8f887e0](8f887e0)) * **deps:** Update module github.com/cloudquery/plugin-sdk/v2 to v2.3.0 ([#10163](#10163)) ([9a7f214](9a7f214)) * **deps:** Update module github.com/cloudquery/plugin-sdk/v2 to v2.3.1 ([#10175](#10175)) ([5b53423](5b53423)) * **deps:** Update module github.com/cloudquery/plugin-sdk/v2 to v2.3.3 ([#10187](#10187)) ([b185248](b185248)) * **deps:** Update module github.com/cloudquery/plugin-sdk/v2 to v2.3.4 ([#10196](#10196)) ([c6d2f59](c6d2f59)) * **deps:** Update module github.com/cloudquery/plugin-sdk/v2 to v2.3.5 ([#10200](#10200)) ([5a33693](5a33693)) * **deps:** Update module github.com/cloudquery/plugin-sdk/v2 to v2.3.6 ([#10208](#10208)) ([91c80a7](91c80a7)) * **deps:** Update module github.com/cloudquery/plugin-sdk/v2 to v2.3.8 ([#10213](#10213)) ([f358666](f358666)) * **deps:** Update module github.com/cloudquery/plugin-sdk/v2 to v2.4.0 ([#10278](#10278)) ([a0a713e](a0a713e)) * **gcp-docs:** Policy docs should include tables used in views ([#10252](#10252)) ([a197db5](a197db5)) * **services:** Update GCP Services ([#10133](#10133)) ([770e260](770e260)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was created by a scheduled workflow to update GCP Services