feat(source/mysql): Upgrade to github.com/cloudquery/plugin-sdk/v2
#10060
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
disq
reviewed
Apr 14, 2023
candiduslynx
added
no automerge
and removed
automerge
yevgenypats
suggested changes
Apr 14, 2023
Contributor
yevgenypats
left a comment
yevgenypats
left a comment
There was a problem hiding this comment.
Given the upgrade is non-trivial I suggest waiting until we rolled out destinations so we can review destination first, learn from that and then move to sources.
Contributor
Author
|
@yevgenypats the non-trivial part is caused only by testing, so the mainline code update was, in fact, trivial. |
candiduslynx
force-pushed
the
feat/plugin-sdk-v2/mysql
branch
from
6a1884e to
3520567
Compare
This reverts commit 9b599f4.
yevgenypats
suggested changes
Apr 19, 2023
kodiakhq bot
pushed a commit
to cloudquery/plugin-sdk
that referenced
this pull request
Apr 19, 2023
yevgenypats
approved these changes
Apr 20, 2023
yevgenypats
added
automerge
erezrokah
approved these changes
Apr 20, 2023
kodiakhq bot
pushed a commit
that referenced
this pull request
Apr 25, 2023
🤖 I have created a release *beep* *boop* --- ## [1.1.0](plugins-source-mysql-v1.0.4...plugins-source-mysql-v1.1.0) (2023-04-25) ### Features * **source/mysql:** Upgrade to `github.com/cloudquery/plugin-sdk/v2` ([#10060](#10060)) ([c5820b0](c5820b0)) ### Bug Fixes * **deps:** Update module github.com/cloudquery/plugin-sdk/v2 to v2.3.8 ([#10213](#10213)) ([f358666](f358666)) * **deps:** Update module github.com/cloudquery/plugin-sdk/v2 to v2.4.0 ([#10278](#10278)) ([a0a713e](a0a713e)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #10034.
It includes some nontrivial code for transformation (that is used solely for tests)