Skip to content

feat(github): Add github_repository_branches table #10044

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kodiakhq merged 10 commits into from
Apr 14, 2023
Merged

feat(github): Add github_repository_branches table #10044

kodiakhq merged 10 commits into from
Apr 14, 2023

Conversation

@patriknordlen
Copy link
Contributor

@patriknordlen patriknordlen commented Apr 14, 2023 •
edited
Loading

Summary

This PR addresses #10020 by adding the table github_repository_branches containing information retrieved from the /repos/{owner}/{repo}/branches and /repos/{owner}/{repo}/branches/{branch}/protection endpoints for each repository and branch.

  • Read the contribution guidelines 🧑‍🎓
  • Run make lint to ensure the proposed changes follow the coding style 🚨 (install golangci-lint here)
  • Run make test to ensure the proposed changes pass the tests 🧪
  • If changing a source plugin run make gen to ensure docs are up to date 📝
  • Ensure the status checks below are successful ✅

@patriknordlen patriknordlen requested review from a team and disq and removed request for a team April 14, 2023 07:14
@github-actions
Copy link

github-actions bot commented Apr 14, 2023

This PR has the following changes to source plugin(s) tables:

  • Table github_repository_branches was added

@candiduslynx candiduslynx self-requested a review April 14, 2023 07:15
@candiduslynx candiduslynx changed the title GitHub repository branches feat(github): Add github_repository_branches table Apr 14, 2023
@candiduslynx
Copy link
Contributor

candiduslynx commented Apr 14, 2023

Hi @patriknordlen!

Thanks for the PR!

Kindly, ensure the following:

  • you ran make gen in the plugin dir
  • fix lint (from plugin dir run golangci-lint run --config ../../.golangci.yml --fix)
  • commit all the changes

@patriknordlen
Copy link
Contributor Author

patriknordlen commented Apr 14, 2023

Hi @patriknordlen!

Thanks for the PR!

Kindly, ensure the following:

* you ran `make gen` in the plugin dir

* fix lint (from plugin dir run `golangci-lint run --config ../../.golangci.yml --fix`)

* commit all the changes

Thanks for the review! I've addressed the format issues highlighted by golangci-lint and committed the fix.

@candiduslynx candiduslynx added the automerge Automatically merge once required checks pass label Apr 14, 2023
@kodiakhq kodiakhq bot merged commit c5eade6 into cloudquery:main Apr 14, 2023
@cq-bot cq-bot mentioned this pull request Apr 14, 2023
Merged
@patriknordlen patriknordlen mentioned this pull request Apr 14, 2023
Closed
1 task
@patriknordlen patriknordlen deleted the github-repository-branches branch April 14, 2023 09:34
@erezrokah
Copy link
Member

erezrokah commented Apr 16, 2023

Hi @patriknordlen thanks for the PR and @candiduslynx for the review. FYI v49 introduced a breaking change in one of the structs we use.

However since the change was to an internal struct that we serialize to JSON as a key value map, and the values seem to be the same, this seems non breaking for us.

@patriknordlen
Copy link
Contributor Author

patriknordlen commented Apr 16, 2023

Hi @patriknordlen thanks for the PR and @candiduslynx for the review. FYI v49 introduced a breaking change in one of the structs we use.

However since the change was to an internal struct that we serialize to JSON as a key value map, and the values seem to be the same, this seems non breaking for us.

I see! The reason for bumping to v49 in this PR was that it addressed a breaking change in Github's API endpoint for fetching branch protections. google/go-github#2612

@erezrokah
Copy link
Member

erezrokah commented Apr 16, 2023

I see! The reason for bumping to v49 in this PR was that it addressed a breaking change in Github's API endpoint for fetching branch protections. google/go-github#2612

Nice! Thanks for the context, makes sense. I'm glad it all worked out (worst case we'd be making a major bump of the plugin, but it's not necessary here)

kodiakhq bot pushed a commit that referenced this pull request Apr 25, 2023
@cq-bot
chore(main): Release plugins-source-github v5.1.0 (#10049)
c819b51 
🤖 I have created a release *beep* *boop*
---


## [5.1.0](plugins-source-github-v5.0.1...plugins-source-github-v5.1.0) (2023-04-25)


### This Release has the Following Changes to Tables
- Table `github_repository_branches` was added

### Features

* **github:** Add `github_repository_branches` table ([#10044](#10044)) ([c5eade6](c5eade6))
* **github:** Upgrade to `github.com/cloudquery/plugin-sdk/v2` ([#10052](#10052)) ([44744e8](44744e8)), closes [#10026](#10026)


### Bug Fixes

* **deps:** Update module github.com/cloudquery/plugin-sdk/v2 to v2.2.0 ([#10135](#10135)) ([cf33b89](cf33b89))
* **deps:** Update module github.com/cloudquery/plugin-sdk/v2 to v2.2.2 ([#10143](#10143)) ([8f887e0](8f887e0))
* **deps:** Update module github.com/cloudquery/plugin-sdk/v2 to v2.3.0 ([#10163](#10163)) ([9a7f214](9a7f214))
* **deps:** Update module github.com/cloudquery/plugin-sdk/v2 to v2.3.1 ([#10175](#10175)) ([5b53423](5b53423))
* **deps:** Update module github.com/cloudquery/plugin-sdk/v2 to v2.3.3 ([#10187](#10187)) ([b185248](b185248))
* **deps:** Update module github.com/cloudquery/plugin-sdk/v2 to v2.3.4 ([#10196](#10196)) ([c6d2f59](c6d2f59))
* **deps:** Update module github.com/cloudquery/plugin-sdk/v2 to v2.3.5 ([#10200](#10200)) ([5a33693](5a33693))
* **deps:** Update module github.com/cloudquery/plugin-sdk/v2 to v2.3.6 ([#10208](#10208)) ([91c80a7](91c80a7))
* **deps:** Update module github.com/cloudquery/plugin-sdk/v2 to v2.3.8 ([#10213](#10213)) ([f358666](f358666))
* **deps:** Update module github.com/cloudquery/plugin-sdk/v2 to v2.4.0 ([#10278](#10278)) ([a0a713e](a0a713e))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@disq disq Awaiting requested review from disq

1 more reviewer

@candiduslynx candiduslynx candiduslynx approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

automerge Automatically merge once required checks pass

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@patriknordlen @candiduslynx @erezrokah @cq-bot