Skip to content

bug(aws): ServiceAccountRegionScopeMultiplexer always creates an item in us-east-1 #10574

@bbernays

Description

@bbernays

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

Currently no matter what the partition is we add an item to fetch from us-east-1

const(
	defaultRegion         = "us-east-1"
	defaultVar            = "default"
	cloudfrontScopeRegion = defaultRegion
)
.
.
.
	// always fetch cloudfront related resources
	l = append(l, client.withPartitionAccountIDRegionAndScope(partition, accountID, cloudfrontScopeRegion, wafv2types.ScopeCloudfront))

We should only do this if we are fetching from the commercial region

Expected Behavior

If you sync from AWS China regions the "cloudfront scope" region should be cn-northwest-1

I think the docs are wrong when stating us-east-1:
https://docs.amazonaws.cn/en_us/waf/latest/APIReference/API_GetWebACL.html

CloudQuery (redacted) config

not necessary

Steps To Reproduce

No response

CloudQuery (redacted) logs

na

CloudQuery version

all

Additional Context

No response

Pull request (optional)

  • I can submit a pull request

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions