feat: Replace DelegationSetId with full DelegationSet in aws_route53_hosted_zones (#12737)

kfritchman46 · web-flow · commit a78012db43ee · 2023-08-07T09:38:28.000Z
#### Summary

The default (not reusable) DelegationSet of AWS public HostedZones are only visible when describing the HostedZone. The DelegationSet API doesn't include them. Sync should include the DelegationSet as a json field of the `aws_route53_hosted_zones` table so changes in Nameservers can be detected.

&lt;!--
diff --git a/plugins/source/aws/resources/services/route53/hosted_zones.go b/plugins/source/aws/resources/services/route53/hosted_zones.go
@@ -79,6 +79,7 @@ func fetchRoute53HostedZones(ctx context.Context, meta schema.ClientMeta, parent
 				HostedZone:      h,
 				Tags:            client.TagsToMap(getTags(*h.Id, tagsResponse.ResourceTagSets)),
 				DelegationSetId: delegationSetId,
+				DelegationSet:   gotHostedZone.DelegationSet,
 				VPCs:            gotHostedZone.VPCs,
 			}
 		}
diff --git a/plugins/source/aws/resources/services/route53/models/route53.go b/plugins/source/aws/resources/services/route53/models/route53.go
@@ -6,5 +6,6 @@ type Route53HostedZoneWrapper struct {
 	types.HostedZone
 	Tags            map[string]string
 	DelegationSetId *string
+	DelegationSet   *types.DelegationSet
 	VPCs            []types.VPC
 }
diff --git a/website/tables/aws/aws_route53_hosted_zones.md b/website/tables/aws/aws_route53_hosted_zones.md
@@ -29,6 +29,7 @@ The following tables depend on aws_route53_hosted_zones:
 |resource_record_set_count|`int64`|
 |tags|`json`|
 |delegation_set_id|`utf8`|
+|delegation_set|`json`|
 |vpcs|`json`|
 
 ## Example Queries

Original file line number	Diff line number	Diff line change
`@@ -79,6 +79,7 @@ func fetchRoute53HostedZones(ctx context.Context, meta schema.ClientMeta, parent`
`79`	`79`	`HostedZone: h,`
`80`	`80`	`Tags: client.TagsToMap(getTags(*h.Id, tagsResponse.ResourceTagSets)),`
`81`	`81`	`DelegationSetId: delegationSetId,`
	`82`	`+ DelegationSet: gotHostedZone.DelegationSet,`
`82`	`83`	`VPCs: gotHostedZone.VPCs,`
`83`	`84`	`}`
`84`	`85`	`}`
Original file line number	Diff line number	Diff line change
`@@ -6,5 +6,6 @@ type Route53HostedZoneWrapper struct {`
`6`	`6`	`types.HostedZone`
`7`	`7`	`Tags map[string]string`
`8`	`8`	`DelegationSetId *string`
	`9`	`+ DelegationSet *types.DelegationSet`
`9`	`10`	`VPCs []types.VPC`
`10`	`11`	`}`