fix: Use Pagination for aws_ec2_images (#13560)

bbernays · web-flow · commit a3779e847651 · 2023-09-01T14:22:46.000Z
#### Summary

Rather than returning all images in a single API call, this PR changes it to use pagination... It will return 1000 images at a time. This will improve performance for large accounts where it is faster to batch the results rather than return them all at once
diff --git a/plugins/source/aws/resources/services/ec2/images.go b/plugins/source/aws/resources/services/ec2/images.go
@@ -54,7 +54,8 @@ func fetchEc2Images(ctx context.Context, meta schema.ClientMeta, parent *schema.
 	g.Go(func() error {
 		// fetch ec2.Images owned by this account
 		pag := ec2.NewDescribeImagesPaginator(svc, &ec2.DescribeImagesInput{
-			Owners: []string{"self"},
+			Owners:     []string{"self"},
+			MaxResults: aws.Int32(1000),
 		})
 		for pag.HasMorePages() {
 			resp, err := pag.NextPage(ctx, func(options *ec2.Options) {
@@ -72,6 +73,7 @@ func fetchEc2Images(ctx context.Context, meta schema.ClientMeta, parent *schema.
 		// fetch ec2.Images that are shared with this account
 		pag := ec2.NewDescribeImagesPaginator(svc, &ec2.DescribeImagesInput{
 			ExecutableUsers: []string{"self"},
+			MaxResults:      aws.Int32(1000),
 		})
 		for pag.HasMorePages() {
 			resp, err := pag.NextPage(ctx, func(options *ec2.Options) {
