fix: Update to SDK v2.3.8, remove release calls (#10262)

erezrokah · web-flow · commit 6ce45b60ea3c · 2023-04-24T10:31:47.000Z
#### Summary Extracted from #10260 as we need to remove the `release` calls for the tests to pass. See https://github.com/cloudquery/cloudquery/actions/runs/4777804922/jobs/8493788491?pr=10260 Same as #10212 <!--
diff --git a/plugins/destination/neo4j/client/read.go b/plugins/destination/neo4j/client/read.go
@@ -85,7 +85,6 @@ func (c *Client) reverseTransformer(sc *arrow.Schema, node *neo4j.Node) (arrow.R
 		}
 	}
 	rec := bldr.NewRecord()
-	bldr.Release()
 	return rec, nil
 }
 
diff --git a/plugins/destination/neo4j/client/transformer.go b/plugins/destination/neo4j/client/transformer.go
@@ -39,7 +39,6 @@ func transformArr(arr arrow.Array) []any {
 			start, end := a.ValueOffsets(i)
 			nested := array.NewSlice(a.ListValues(), start, end)
 			pgArr[i] = transformArr(nested)
-			nested.Release()
 		default:
 			pgArr[i] = arr.ValueStr(i)
 		}
diff --git a/plugins/destination/neo4j/client/write.go b/plugins/destination/neo4j/client/write.go
@@ -16,7 +16,6 @@ func (c *Client) WriteTableBatch(ctx context.Context, table *arrow.Schema, recor
 	rows := make([]map[string]any, 0)
 	for _, record := range records {
 		rows = append(rows, transformValues(record)...)
-		record.Release()
 	}
 	var sb strings.Builder
 	sb.WriteString("UNWIND $rows AS row MERGE (t:")
diff --git a/plugins/destination/neo4j/go.mod b/plugins/destination/neo4j/go.mod
@@ -4,7 +4,7 @@ go 1.19
 
 require (
 	github.com/apache/arrow/go/v12 v12.0.0-20230418061731-a2548a79a191
-	github.com/cloudquery/plugin-sdk/v2 v2.3.6
+	github.com/cloudquery/plugin-sdk/v2 v2.3.8
 	github.com/neo4j/neo4j-go-driver/v5 v5.6.0
 	github.com/rs/zerolog v1.29.0
 )
diff --git a/plugins/destination/neo4j/go.sum b/plugins/destination/neo4j/go.sum
@@ -47,8 +47,8 @@ github.com/chzyer/test v0.0.0-20180213035817-a1ea475d72b1/go.mod h1:Q3SI9o4m/ZMn
 github.com/client9/misspell v0.3.4/go.mod h1:qj6jICC3Q7zFZvVWo7KLAzC3yx5G7kyvSDkc90ppPyw=
 github.com/cloudquery/arrow/go/v12 v12.0.0-20230416141001-e8315b3fff1c h1:ChEK/kvdvnnugPJqCpMbmCe8LwMmi/quMD5WtQig/1w=
 github.com/cloudquery/arrow/go/v12 v12.0.0-20230416141001-e8315b3fff1c/go.mod h1:d+tV/eHZZ7Dz7RPrFKtPK02tpr+c9/PEd/zm8mDS9Vg=
-github.com/cloudquery/plugin-sdk/v2 v2.3.6 h1:fzsmALscu9w6pZNB+6Aj4cobhqCCKorCDjV3EtkF8Ao=
-github.com/cloudquery/plugin-sdk/v2 v2.3.6/go.mod h1:/wAbhyQbdIUAMEL+Yo9zkgoBls83xt3ev6jLpJblIoU=
+github.com/cloudquery/plugin-sdk/v2 v2.3.8 h1:6UzliJ1TW70Y40aQIQv6AXBY5ra7sWtlBo12UQsGF2A=
+github.com/cloudquery/plugin-sdk/v2 v2.3.8/go.mod h1:/wAbhyQbdIUAMEL+Yo9zkgoBls83xt3ev6jLpJblIoU=
 github.com/cncf/udpa/go v0.0.0-20191209042840-269d4d468f6f/go.mod h1:M8M6+tZqaGXZJjfX53e64911xZQV5JYwmTeXPW+k8Sc=
 github.com/cncf/udpa/go v0.0.0-20201120205902-5459f2c99403/go.mod h1:WmhPx2Nbnhtbo57+VJT5O0JRkEi1Wbu0z5j0R8u5Hbk=
 github.com/coreos/go-systemd v0.0.0-20190321100706-95778dfbb74e/go.mod h1:F5haX7vjVVG0kc13fIWeqUViNPyEJxv/OmvnBo0Yme4=

Original file line number	Diff line number	Diff line change
`@@ -85,7 +85,6 @@ func (c Client) reverseTransformer(sc arrow.Schema, node *neo4j.Node) (arrow.R`
`85`	`85`	`}`
`86`	`86`	`}`
`87`	`87`	`rec := bldr.NewRecord()`
`88`		`- bldr.Release()`
`89`	`88`	`return rec, nil`
`90`	`89`	`}`
`91`	`90`
Original file line number	Diff line number	Diff line change
`@@ -39,7 +39,6 @@ func transformArr(arr arrow.Array) []any {`
`39`	`39`	`start, end := a.ValueOffsets(i)`
`40`	`40`	`nested := array.NewSlice(a.ListValues(), start, end)`
`41`	`41`	`pgArr[i] = transformArr(nested)`
`42`		`- nested.Release()`
`43`	`42`	`default:`
`44`	`43`	`pgArr[i] = arr.ValueStr(i)`
`45`	`44`	`}`
Original file line number	Diff line number	Diff line change
`@@ -16,7 +16,6 @@ func (c Client) WriteTableBatch(ctx context.Context, table arrow.Schema, recor`
`16`	`16`	`rows := make([]map[string]any, 0)`
`17`	`17`	`for _, record := range records {`
`18`	`18`	`rows = append(rows, transformValues(record)...)`
`19`		`- record.Release()`
`20`	`19`	`}`
`21`	`20`	`var sb strings.Builder`
`22`	`21`	`sb.WriteString("UNWIND $rows AS row MERGE (t:")`
Original file line number	Diff line number	Diff line change
`@@ -4,7 +4,7 @@ go 1.19`
`4`	`4`
`5`	`5`	`require (`
`6`	`6`	`github.com/apache/arrow/go/v12 v12.0.0-20230418061731-a2548a79a191`
`7`		`- github.com/cloudquery/plugin-sdk/v2 v2.3.6`
	`7`	`+ github.com/cloudquery/plugin-sdk/v2 v2.3.8`
`8`	`8`	`github.com/neo4j/neo4j-go-driver/v5 v5.6.0`
`9`	`9`	`github.com/rs/zerolog v1.29.0`
`10`	`10`	`)`