fix: Handle NoConnection (#14112)

erezrokah · web-flow · commit 691ddd4b069e · 2023-09-28T08:53:08.000Z
#### Summary See https://github.com/cloudquery/cloudquery/actions/runs/6328679225/job/17187394279#step:6:89 I missed this in #14102. If we pass empty tables to `FilterDfs` it fails since there are no matches. <!--
diff --git a/plugins/source/firestore/client/client.go b/plugins/source/firestore/client/client.go
@@ -85,6 +85,9 @@ func Configure(ctx context.Context, logger zerolog.Logger, spec []byte, opts plu
 }
 
 func (c Client) Tables(ctx context.Context, opts plugin.TableOptions) (schema.Tables, error) {
+	if c.options.NoConnection {
+		return schema.Tables{}, nil
+	}
 	return c.tables.FilterDfs(opts.Tables, opts.SkipTables, opts.SkipDependentTables)
 }
 

Original file line number	Diff line number	Diff line change
`@@ -85,6 +85,9 @@ func Configure(ctx context.Context, logger zerolog.Logger, spec []byte, opts plu`
`85`	`85`	`}`
`86`	`86`
`87`	`87`	`func (c Client) Tables(ctx context.Context, opts plugin.TableOptions) (schema.Tables, error) {`
	`88`	`+ if c.options.NoConnection {`
	`89`	`+ return schema.Tables{}, nil`
	`90`	`+ }`
`88`	`91`	`return c.tables.FilterDfs(opts.Tables, opts.SkipTables, opts.SkipDependentTables)`
`89`	`92`	`}`
`90`	`93`