fix: Update to SDK v2.3.8, remove release calls (#10263)

erezrokah · web-flow · commit 678380691ca6 · 2023-04-24T10:27:40.000Z
#### Summary Same as #10262 for Snowflake <!--
diff --git a/plugins/destination/snowflake/client/write.go b/plugins/destination/snowflake/client/write.go
@@ -36,13 +36,9 @@ func (c *Client) WriteTableBatch(ctx context.Context, table *arrow.Schema, resou
 		enc.SetEscapeHTML(false)
 		for i := 0; i < arr.Len(); i++ {
 			if err := enc.Encode(arr.GetOneForMarshal(i)); err != nil {
-				arr.Release()
-				r.Release()
 				return err
 			}
 		}
-		arr.Release()
-		r.Release()
 	}
 
 	if err := f.Close(); err != nil {
diff --git a/plugins/destination/snowflake/go.mod b/plugins/destination/snowflake/go.mod
@@ -4,7 +4,7 @@ go 1.19
 
 require (
 	github.com/apache/arrow/go/v12 v12.0.0-20230418102323-1deb740e02fa
-	github.com/cloudquery/plugin-sdk/v2 v2.3.6
+	github.com/cloudquery/plugin-sdk/v2 v2.3.8
 	github.com/rs/zerolog v1.29.0
 	github.com/snowflakedb/gosnowflake v1.6.18
 )
diff --git a/plugins/destination/snowflake/go.sum b/plugins/destination/snowflake/go.sum
@@ -110,8 +110,8 @@ github.com/chzyer/test v0.0.0-20180213035817-a1ea475d72b1/go.mod h1:Q3SI9o4m/ZMn
 github.com/client9/misspell v0.3.4/go.mod h1:qj6jICC3Q7zFZvVWo7KLAzC3yx5G7kyvSDkc90ppPyw=
 github.com/cloudquery/arrow/go/v12 v12.0.0-20230416141001-e8315b3fff1c h1:ChEK/kvdvnnugPJqCpMbmCe8LwMmi/quMD5WtQig/1w=
 github.com/cloudquery/arrow/go/v12 v12.0.0-20230416141001-e8315b3fff1c/go.mod h1:d+tV/eHZZ7Dz7RPrFKtPK02tpr+c9/PEd/zm8mDS9Vg=
-github.com/cloudquery/plugin-sdk/v2 v2.3.6 h1:fzsmALscu9w6pZNB+6Aj4cobhqCCKorCDjV3EtkF8Ao=
-github.com/cloudquery/plugin-sdk/v2 v2.3.6/go.mod h1:/wAbhyQbdIUAMEL+Yo9zkgoBls83xt3ev6jLpJblIoU=
+github.com/cloudquery/plugin-sdk/v2 v2.3.8 h1:6UzliJ1TW70Y40aQIQv6AXBY5ra7sWtlBo12UQsGF2A=
+github.com/cloudquery/plugin-sdk/v2 v2.3.8/go.mod h1:/wAbhyQbdIUAMEL+Yo9zkgoBls83xt3ev6jLpJblIoU=
 github.com/cncf/udpa/go v0.0.0-20191209042840-269d4d468f6f/go.mod h1:M8M6+tZqaGXZJjfX53e64911xZQV5JYwmTeXPW+k8Sc=
 github.com/cncf/udpa/go v0.0.0-20201120205902-5459f2c99403/go.mod h1:WmhPx2Nbnhtbo57+VJT5O0JRkEi1Wbu0z5j0R8u5Hbk=
 github.com/cncf/xds/go v0.0.0-20210312221358-fbca930ec8ed/go.mod h1:eXthEFrGJvWHgFFCl3hGmgk+/aYT6PnTQLykKQRLhEs=

Original file line number	Diff line number	Diff line change
`@@ -36,13 +36,9 @@ func (c Client) WriteTableBatch(ctx context.Context, table arrow.Schema, resou`
`36`	`36`	`enc.SetEscapeHTML(false)`
`37`	`37`	`for i := 0; i < arr.Len(); i++ {`
`38`	`38`	`if err := enc.Encode(arr.GetOneForMarshal(i)); err != nil {`
`39`		`- arr.Release()`
`40`		`- r.Release()`
`41`	`39`	`return err`
`42`	`40`	`}`
`43`	`41`	`}`
`44`		`- arr.Release()`
`45`		`- r.Release()`
`46`	`42`	`}`
`47`	`43`
`48`	`44`	`if err := f.Close(); err != nil {`
Original file line number	Diff line number	Diff line change
`@@ -4,7 +4,7 @@ go 1.19`
`4`	`4`
`5`	`5`	`require (`
`6`	`6`	`github.com/apache/arrow/go/v12 v12.0.0-20230418102323-1deb740e02fa`
`7`		`- github.com/cloudquery/plugin-sdk/v2 v2.3.6`
	`7`	`+ github.com/cloudquery/plugin-sdk/v2 v2.3.8`
`8`	`8`	`github.com/rs/zerolog v1.29.0`
`9`	`9`	`github.com/snowflakedb/gosnowflake v1.6.18`
`10`	`10`	`)`