fix: Update to SDK v2.3.7, remove release calls (#10209)

erezrokah · web-flow · commit 544283754bda · 2023-04-20T10:49:20.000Z
#### Summary Follow up to cloudquery/plugin-sdk#810 <!--
diff --git a/plugins/destination/mysql/client/read.go b/plugins/destination/mysql/client/read.go
@@ -74,7 +74,6 @@ func (*Client) createResultsArray(table *arrow.Schema) []any {
 
 func reverseTransform(table *arrow.Schema, values []any) (arrow.Record, error) {
 	recordBuilder := array.NewRecordBuilder(memory.DefaultAllocator, table)
-	defer recordBuilder.Release()
 	for i, val := range values {
 		switch table.Field(i).Type.(type) {
 		case *arrow.BooleanType:
diff --git a/plugins/destination/mysql/client/write.go b/plugins/destination/mysql/client/write.go
@@ -32,12 +32,10 @@ func (c *Client) writeResources(ctx context.Context, query string, resources []a
 	for _, data := range resources {
 		transformedRecords, err := transformRecord(data)
 		if err != nil {
-			data.Release()
 			return err
 		}
 		for _, transformedRecord := range transformedRecords {
 			_, err := c.db.ExecContext(ctx, query, transformedRecord...)
-			data.Release()
 			if err != nil {
 				return err
 			}
diff --git a/plugins/destination/mysql/go.mod b/plugins/destination/mysql/go.mod
@@ -4,7 +4,7 @@ go 1.19
 
 require (
 	github.com/apache/arrow/go/v12 v12.0.0-20230401212133-adf33cc43010
-	github.com/cloudquery/plugin-sdk/v2 v2.3.6
+	github.com/cloudquery/plugin-sdk/v2 v2.3.7
 	github.com/go-sql-driver/mysql v1.7.0
 	github.com/google/uuid v1.3.0
 	github.com/rs/zerolog v1.29.0
diff --git a/plugins/destination/mysql/go.sum b/plugins/destination/mysql/go.sum
@@ -47,8 +47,8 @@ github.com/chzyer/test v0.0.0-20180213035817-a1ea475d72b1/go.mod h1:Q3SI9o4m/ZMn
 github.com/client9/misspell v0.3.4/go.mod h1:qj6jICC3Q7zFZvVWo7KLAzC3yx5G7kyvSDkc90ppPyw=
 github.com/cloudquery/arrow/go/v12 v12.0.0-20230411134648-a5b71cd453c8 h1:v4ST367e8h0VyazUy3O/8soQzpHHGxH/8Jng9YlhZH8=
 github.com/cloudquery/arrow/go/v12 v12.0.0-20230411134648-a5b71cd453c8/go.mod h1:d+tV/eHZZ7Dz7RPrFKtPK02tpr+c9/PEd/zm8mDS9Vg=
-github.com/cloudquery/plugin-sdk/v2 v2.3.6 h1:fzsmALscu9w6pZNB+6Aj4cobhqCCKorCDjV3EtkF8Ao=
-github.com/cloudquery/plugin-sdk/v2 v2.3.6/go.mod h1:/wAbhyQbdIUAMEL+Yo9zkgoBls83xt3ev6jLpJblIoU=
+github.com/cloudquery/plugin-sdk/v2 v2.3.7 h1:tDRi61+NzIfOORxrRjP48E2bM322maWoVZi2E6VR0rI=
+github.com/cloudquery/plugin-sdk/v2 v2.3.7/go.mod h1:/wAbhyQbdIUAMEL+Yo9zkgoBls83xt3ev6jLpJblIoU=
 github.com/cncf/udpa/go v0.0.0-20191209042840-269d4d468f6f/go.mod h1:M8M6+tZqaGXZJjfX53e64911xZQV5JYwmTeXPW+k8Sc=
 github.com/cncf/udpa/go v0.0.0-20201120205902-5459f2c99403/go.mod h1:WmhPx2Nbnhtbo57+VJT5O0JRkEi1Wbu0z5j0R8u5Hbk=
 github.com/coreos/go-systemd v0.0.0-20190321100706-95778dfbb74e/go.mod h1:F5haX7vjVVG0kc13fIWeqUViNPyEJxv/OmvnBo0Yme4=

Original file line number	Diff line number	Diff line change
`@@ -32,12 +32,10 @@ func (c *Client) writeResources(ctx context.Context, query string, resources []a`
`32`	`32`	`for _, data := range resources {`
`33`	`33`	`transformedRecords, err := transformRecord(data)`
`34`	`34`	`if err != nil {`
`35`		`- data.Release()`
`36`	`35`	`return err`
`37`	`36`	`}`
`38`	`37`	`for _, transformedRecord := range transformedRecords {`
`39`	`38`	`_, err := c.db.ExecContext(ctx, query, transformedRecord...)`
`40`		`- data.Release()`
`41`	`39`	`if err != nil {`
`42`	`40`	`return err`
`43`	`41`	`}`