Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #91 +/- ##
==========================================
+ Coverage 79.88% 80.62% +0.74%
==========================================
Files 2 2
Lines 522 542 +20
Branches 109 111 +2
==========================================
+ Hits 417 437 +20
Misses 75 75
Partials 30 30
Continue to review full report at Codecov.
|
pitrou
reviewed
May 31, 2017
cloudpickle/cloudpickle.py
Outdated
| return _empty_cell_value | ||
|
|
||
|
|
||
| @object.__new__ |
Contributor
Author
There was a problem hiding this comment.
I have wrapped this in a named function with a docstring.
Idk if this is better.
pitrou
reviewed
Jun 2, 2017
| return _empty_cell_value | ||
|
|
||
|
|
||
| def instance(cls): |
Member
There was a problem hiding this comment.
Should this just go back to @object.__new__? 😄
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
addresses #73