[Bug]: Incorrect object name logged when barman object configuration not found

In the pre-hook, when we check for the ObjectStore objects, if one object is not present, we always log
the name of the ObjectStore referred to in the main plugin section. This makes it extremely difficult to debug issues from externalCluster with the wrong object store name..

plugin-barman-cloud/internal/cnpgi/operator/reconciler.go

Lines 78 to 95 in f484b9e

    
           for _, barmanObjectKey := range pluginConfiguration.GetReferredBarmanObjectsKey() { 
        
           	var barmanObject barmancloudv1.ObjectStore 
        
           	if err := r.Client.Get(ctx, barmanObjectKey, &barmanObject); err != nil { 
        
           		if apierrs.IsNotFound(err) { 
        
           			contextLogger.Info( 
        
           				"barman object configuration not found, requeuing", 
        
           				"name", pluginConfiguration.BarmanObjectName, 
        
           				"namespace", cluster.Namespace) 
        
           			return &reconciler.ReconcilerHooksResult{ 
        
           				Behavior: reconciler.ReconcilerHooksResult_BEHAVIOR_REQUEUE, 
        
           			}, nil 
        
           		} 
        
           		return nil, err 
        
           	} 
        
           	barmanObjects = append(barmanObjects, barmanObject) 
        
           }

The logging issue happens because the code logs the main plugin's barmanObjectName when an ObjectStore is missing, regardless of which reference actually failed. This means if an externalCluster references a different ObjectStore and it's missing, the log will still show the main plugin's name, making debugging confusing when multiple ObjectStores are involved. The relevant code in the pre-hook iterates over all referred ObjectStore keys, but always logs pluginConfiguration.BarmanObjectName instead of the actual missing key's name. To improve debugging, the log should use the name of the missing ObjectStore key being checked, not the main plugin's name. No recent PRs address this, so for now, double-check all ObjectStore references in both plugin and externalCluster specs if you see this log message. More granular logging is a common user request for this scenario source code.

To reply, just mention @dosu.

Share context across your team and agents. Try Dosu.

fix(logs): log the correct name when on ObjectStore not found error

fix(logs): log the correct name when on ObjectStore not found error (#…

fix(logs): log the correct name when on ObjectStore not found error (c…

feat(container): update image ghcr.io/cloudnative-pg/charts/plugin-ba…

chore(deps): update dependency https://github.com/cloudnative-pg/plug…

Navigation Menu

Repository navigation

[Bug]: Incorrect object name logged when barman object configuration not found #539

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	for _, barmanObjectKey := range pluginConfiguration.GetReferredBarmanObjectsKey() {
	var barmanObject barmancloudv1.ObjectStore
	if err := r.Client.Get(ctx, barmanObjectKey, &barmanObject); err != nil {
	if apierrs.IsNotFound(err) {
	contextLogger.Info(
	"barman object configuration not found, requeuing",
	"name", pluginConfiguration.BarmanObjectName,
	"namespace", cluster.Namespace)
	return &reconciler.ReconcilerHooksResult{
	Behavior: reconciler.ReconcilerHooksResult_BEHAVIOR_REQUEUE,
	}, nil
	}

	return nil, err
	}

	barmanObjects = append(barmanObjects, barmanObject)
	}

[Bug]: Incorrect object name logged when barman object configuration not found #539

Description

Activity

dosubot commented on Sep 19, 2025

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions