Skip to content

test(targetTime): add E2E for PITR with targetTime specified in RFC3339 format - #8981

Merged
mnencia merged 12 commits into
mainfrom
test-rfc3339-pitr-e2e
Feb 17, 2026
Merged

mnencia merged 12 commits into
mainfrom
test-rfc3339-pitr-e2e

Conversation

@jsilvela

@jsilvela jsilvela commented Oct 28, 2025 •

Copy link
Copy Markdown
Contributor

Exercises the machinery fix (cloudnative-pg/machinery#168) that allows RFC3339 timestamps in recovery_target_time. The existing PITR snapshot test is extended to also restore with an RFC3339-formatted targetTime, ensuring both formats work end-to-end.

Ref: #8937, cloudnative-pg/machinery#167

@jsilvela
jsilvela requested a review from a team October 28, 2025 15:07
@dosubot dosubot Bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Oct 28, 2025
@jsilvela
jsilvela marked this pull request as draft October 28, 2025 15:07
@cnpg-bot cnpg-bot added backport-requested ◀️ This pull request should be backported to all supported releases release-1.25 labels Oct 28, 2025
@github-actions

Copy link
Copy Markdown
Contributor

❗ By default, the pull request is configured to backport to all release branches.

  • To stop backporting this pr, remove the label: backport-requested ◀️ or add the label 'do not backport'
  • To stop backporting this pr to a certain release branch, remove the specific branch label: release-x.y

@dosubot dosubot Bot added the E2E tests E2E tests tickets for easy triage on release process label Oct 28, 2025
@jsilvela

Copy link
Copy Markdown
Contributor Author

/test feature_type=snapshot test_level=4

@github-actions

Copy link
Copy Markdown
Contributor

@jsilvela

jsilvela commented Oct 28, 2025 •

Copy link
Copy Markdown
Contributor Author

Systematic failure for the PITR recovery with timestamp in RFC3339.
Matches the manual testing done in #8937

We're probably doing something wrong in func ConvertToPostgresFormat(timestamp string) string {, when doing conversion from RFC3339 / RFC3339, but not sure what it could be.

volume-snapshot-recovery-4-1392/cluster-pvc-snapshot-recovery-1-snapshot-recovery-jl6ws/snapshot-recovery.log:
{"level":"info","ts":"2025-10-28T16:40:20.32447612Z",
  "logger":"pg_ctl",
  "msg":"waiting for server to start....2025-10-28 16:40:20.324 UTC [38] LOG:  invalid value for parameter \"recovery_target_time\": \"2025-10-28 16:34:15.000000Z\"",
  "pipe":"stdout","logging_pod":"cluster-pvc-snapshot-recovery-1-snapshot-recovery"}

@jsilvela jsilvela changed the title test: check RFC3339 is valid for recovery_target_time test: check RFC3339 is valid for recoveryTarget.targetTime Oct 28, 2025
@jsilvela

Copy link
Copy Markdown
Contributor Author

/test depth=push test_level=4 feature_type=snapshot

@github-actions

Copy link
Copy Markdown
Contributor

@jsilvela

Copy link
Copy Markdown
Contributor Author

/test depth=push test_level=4 feature_type=snapshot

@github-actions

Copy link
Copy Markdown
Contributor

@cnpg-bot cnpg-bot added the ok to merge 👌 This PR can be merged label Oct 29, 2025
@jsilvela

Copy link
Copy Markdown
Contributor Author

Changing the trailing Z from an RFC3339 stamp to +00 will make the recovery time setting work fine.

@jsilvela

Copy link
Copy Markdown
Contributor Author

/test depth=push test_level=4 feature_type=snapshot

@github-actions

Copy link
Copy Markdown
Contributor

@jsilvela

Copy link
Copy Markdown
Contributor Author

Changing the trailing Z from an RFC3339 stamp to +00, and the separating space to T will make the recovery time setting work fine.

@jsilvela

Copy link
Copy Markdown
Contributor Author

/test depth=push test_level=4 feature_type=snapshot

@github-actions

Copy link
Copy Markdown
Contributor

@jsilvela

Copy link
Copy Markdown
Contributor Author

/test depth=push test_level=4 feature_type=snapshot

@github-actions

Copy link
Copy Markdown
Contributor

@github-actions

Copy link
Copy Markdown
Contributor

@jsilvela

jsilvela commented Jan 2, 2026

Copy link
Copy Markdown
Contributor Author

/test depth=push test_level=4 feature_type=snapshot

@github-actions

github-actions Bot commented Jan 2, 2026

Copy link
Copy Markdown
Contributor

@jsilvela
jsilvela force-pushed the test-rfc3339-pitr-e2e branch from 1835c9e to d97d62a Compare February 2, 2026 11:55
@jsilvela

jsilvela commented Feb 2, 2026

Copy link
Copy Markdown
Contributor Author

/test depth=push test_level=4 feature_type=snapshot

@github-actions

github-actions Bot commented Feb 2, 2026

Copy link
Copy Markdown
Contributor

@dosubot dosubot Bot added the lgtm This PR has been approved by a maintainer label Feb 16, 2026
@armru armru added do not backport This PR must not be backported - it will be in the next minor release and removed backport-requested ◀️ This pull request should be backported to all supported releases release-1.25 release-1.28 labels Feb 16, 2026

@gabriele-wolfox gabriele-wolfox left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mnencia
mnencia force-pushed the test-rfc3339-pitr-e2e branch from d97d62a to 927ad52 Compare February 17, 2026 16:43
@mnencia
mnencia merged commit 40d26b0 into main Feb 17, 2026
35 checks passed
@mnencia
mnencia deleted the test-rfc3339-pitr-e2e branch February 17, 2026 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do not backport This PR must not be backported - it will be in the next minor release E2E tests E2E tests tickets for easy triage on release process lgtm This PR has been approved by a maintainer no-issue ok to merge 👌 This PR can be merged size:L This PR changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants