Repository navigation
feat(instance): add cnpgi metrics capabilities to the instance webserver - #8033
Merged
Merged
Conversation
cnpg-bot
added
backport-requested ◀️
Contributor
|
❗ By default, the pull request is configured to backport to all release branches.
|
armru
force-pushed
the
dev/plugin-metrics
branch
2 times, most recently
from
July 14, 2025 14:25
af8dd17 to
a11995e
Compare
Member
Author
|
/test limit=local |
Contributor
|
@armru, here's the link to the E2E on CNPG workflow run: https://github.com/cloudnative-pg/cloudnative-pg/actions/runs/16269566998 |
armru
added
do not backport
armru
changed the title
metrics capabilities to the instance metrics webservermetrics capabilities to the instance webserver
armru
force-pushed
the
dev/plugin-metrics
branch
2 times, most recently
from
July 15, 2025 14:01
7801cff to
732299f
Compare
armru
marked this pull request as ready for review
July 15, 2025 14:03
dosubot
Bot
added
size:XL
mnencia
force-pushed
the
dev/plugin-metrics
branch
from
July 18, 2025 13:59
6170595 to
4ded721
Compare
2 tasks done
mnencia
force-pushed
the
dev/plugin-metrics
branch
4 times, most recently
from
July 22, 2025 12:51
88f0d3e to
d22e10e
Compare
mnencia
force-pushed
the
dev/plugin-metrics
branch
from
July 22, 2025 13:18
d22e10e to
f39d63a
Compare
mnencia
approved these changes
Jul 22, 2025
mnencia
force-pushed
the
dev/plugin-metrics
branch
from
July 22, 2025 14:21
f39d63a to
bcc2617
Compare
Member
|
/test |
Contributor
|
@mnencia, here's the link to the E2E on CNPG workflow run: https://github.com/cloudnative-pg/cloudnative-pg/actions/runs/16447086260 |
…s webserver Signed-off-by: Armando Ruocco <[email protected]> feat(instance,cnpgi): add `metrics` capabilities to the instance metrics webserver This commit makes it possible for the plugins to export metrics to the instance metrics webserver. This work will also enable future patches to integrate the metrics that we previously had with in tree barman but are now not present in the plugin Signed-off-by: Armando Ruocco <[email protected]>
Signed-off-by: Armando Ruocco <[email protected]>
Signed-off-by: Armando Ruocco <[email protected]>
Signed-off-by: Armando Ruocco <[email protected]>
Signed-off-by: Armando Ruocco <[email protected]>
leonardoce
force-pushed
the
dev/plugin-metrics
branch
from
July 22, 2025 15:39
bcc2617 to
88bc3a6
Compare
Signed-off-by: Leonardo Cecchi <[email protected]>
Contributor
|
/test limit=local |
Contributor
|
@leonardoce, here's the link to the E2E on CNPG workflow run: https://github.com/cloudnative-pg/cloudnative-pg/actions/runs/16467320928 |
Contributor
|
I tested it manually and verified that a plugin is able to expose custom metrics. |
leonardoce
approved these changes
Jul 23, 2025
4 tasks done
gbartolini
pushed a commit
to cloudnative-pg/plugin-barman-cloud
that referenced
this pull request
Aug 7, 2025
Introduce two new Prometheus metrics sourced from the Barman Cloud plugin: - `barman_cloud_cloudnative_pg_io_first_recoverability_point` - `barman_cloud_cloudnative_pg_io_last_available_backup_timestamp` These metrics supersede the following deprecated CNPG metrics: - `cnpg_collector_first_recoverability_point` - `cnpg_collector_last_available_backup_timestamp` Depends on: cloudnative-pg/cloudnative-pg#8033 Relates to: #380 Signed-off-by: Armando Ruocco <[email protected]> Signed-off-by: Leonardo Cecchi <[email protected]> Co-authored-by: Leonardo Cecchi <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed solution
This commit allows the plugins to export metrics to the instance metrics web server.
This work will also enable future patches to integrate the metrics that we previously had with in-tree barman, but that are now absent from the plugin.
Requires cloudnative-pg/cnpg-i#219
Relates #7812
Alternate solution
Do not implement the metrics interface and require that the users scrape the sidecar containers directly