Skip to content

refactor: roles controller - #5973

Closed
jsilvela wants to merge 5 commits into
cloudnative-pg:mainfrom
EnterpriseDB:dev/refactor-role-controler
Closed

jsilvela wants to merge 5 commits into
cloudnative-pg:mainfrom
EnterpriseDB:dev/refactor-role-controler

Conversation

@jsilvela

@jsilvela jsilvela commented Oct 29, 2024 •

Copy link
Copy Markdown
Contributor

Closes #5997

IMPORTANT for reviewers

The CRD parts of this PR are being moved to #6155
This branch is to contain ONLY the refactoring bits.

@jsilvela
jsilvela requested a review from a team October 29, 2024 18:07
@jsilvela
jsilvela marked this pull request as draft October 29, 2024 18:07
@cnpg-bot cnpg-bot added backport-requested ◀️ This pull request should be backported to all supported releases release-1.22 labels Oct 29, 2024
@github-actions

Copy link
Copy Markdown
Contributor

❗ By default, the pull request is configured to backport to all release branches.

  • To stop backporting this pr, remove the label: backport-requested ◀️ or add the label 'do not backport'
  • To stop backporting this pr to a certain release branch, remove the specific branch label: release-x.y

@jsilvela
jsilvela force-pushed the dev/refactor-role-controler branch from 108bbe0 to 7ac539e Compare October 31, 2024 14:24
@jsilvela jsilvela added the do not merge 🙅 This PR cannot be merged (yet) label Oct 31, 2024
@jsilvela
jsilvela marked this pull request as ready for review October 31, 2024 14:37
@gabriele-wolfox
gabriele-wolfox force-pushed the dev/refactor-role-controler branch 5 times, most recently from 4624451 to bc42a28 Compare November 8, 2024 15:50
@jsilvela
jsilvela force-pushed the dev/refactor-role-controler branch from b0ce924 to b25c1bd Compare November 11, 2024 13:56
@gabriele-wolfox
gabriele-wolfox force-pushed the dev/refactor-role-controler branch 3 times, most recently from e8b050a to 92ed2e2 Compare November 11, 2024 16:16
@jsilvela
jsilvela force-pushed the dev/refactor-role-controler branch from c86652b to 1f0050a Compare November 21, 2024 17:26
@gabriele-wolfox
gabriele-wolfox force-pushed the dev/refactor-role-controler branch from 1f0050a to bebf656 Compare November 22, 2024 08:34
@mnencia
mnencia force-pushed the dev/refactor-role-controler branch from bebf656 to 59face1 Compare November 22, 2024 09:29
@jsilvela
jsilvela force-pushed the dev/refactor-role-controler branch 2 times, most recently from de5b99d to 87a3e82 Compare November 22, 2024 11:16
@jsilvela jsilvela removed the do not merge 🙅 This PR cannot be merged (yet) label Nov 22, 2024
@jsilvela
jsilvela force-pushed the dev/refactor-role-controler branch from d1758f4 to c408d3a Compare November 25, 2024 09:24
@jsilvela

Copy link
Copy Markdown
Contributor Author

/test

@github-actions

Copy link
Copy Markdown
Contributor

@NiccoloFei
NiccoloFei force-pushed the dev/refactor-role-controler branch from c408d3a to 909ce97 Compare November 26, 2024 16:34
@NiccoloFei
NiccoloFei force-pushed the dev/refactor-role-controler branch from 98c9503 to 77f9bf6 Compare November 27, 2024 11:35
@NiccoloFei

Copy link
Copy Markdown
Collaborator

/test depth=push

@github-actions

Copy link
Copy Markdown
Contributor

@cnpg-bot cnpg-bot added the ok to merge 👌 This PR can be merged label Nov 27, 2024
@mnencia
mnencia force-pushed the dev/refactor-role-controler branch from 77f9bf6 to 135ace8 Compare November 27, 2024 17:29
@jsilvela jsilvela closed this Feb 11, 2025
@jsilvela
jsilvela deleted the dev/refactor-role-controler branch February 11, 2025 10:07
@github-actions

Copy link
Copy Markdown
Contributor

❗ By default, the pull request is configured to backport to all release branches.

  • To stop backporting this pr, remove the label: backport-requested ◀️ or add the label 'do not backport'
  • To stop backporting this pr to a certain release branch, remove the specific branch label: release-x.y

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-requested ◀️ This pull request should be backported to all supported releases ok to merge 👌 This PR can be merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Refactor]: make the relevant parts of the managed roles code Public for reuse

5 participants