Repository navigation
feat: move shutdown logic to instance management - #3039
Merged
Merged
Conversation
leonardoce
requested review from
armru,
fcanovai,
gbartolini,
mnencia,
phisco and
sxd
as code owners
October 10, 2023 08:05
github-actions
Bot
added
backport-requested ◀️
Contributor
|
❗ By default, the pull request is configured to backport to all release branches.
|
Signed-off-by: Marco Nenciarini <[email protected]>
Signed-off-by: Armando Ruocco <[email protected]>
Signed-off-by: Gabriele Bartolini <[email protected]>
Signed-off-by: Leonardo Cecchi <[email protected]>
Signed-off-by: Gabriele Bartolini <[email protected]>
Contributor
Author
|
/ok-to-merge |
mnencia
approved these changes
Oct 10, 2023
gbartolini
approved these changes
Oct 10, 2023
leonardoce
added a commit
that referenced
this pull request
Oct 10, 2023
This patch moves the shutdown logic from the lifecycle manager to the instance manager, simplifying its structure. The `.spec.smartStopDelay` field is used now as the time given to the PostgreSQL smart shutdown sequence. After that, we'll request PostgreSQL to shut down using the `fast` strategy within the overall `.spec.stopDelay` time, which is the `terminationGracePeriodSeconds` of the Pods. Closes #3032 Signed-off-by: Marco Nenciarini <[email protected]> Signed-off-by: Armando Ruocco <[email protected]> Signed-off-by: Gabriele Bartolini <[email protected]> Signed-off-by: Leonardo Cecchi <[email protected]> Co-authored-by: Marco Nenciarini <[email protected]> Co-authored-by: Armando Ruocco <[email protected]> Co-authored-by: Gabriele Bartolini <[email protected]>
leonardoce
added a commit
that referenced
this pull request
Oct 10, 2023
This patch moves the shutdown logic from the lifecycle manager to the instance manager, simplifying its structure. The `.spec.smartStopDelay` field is used now as the time given to the PostgreSQL smart shutdown sequence. After that, we'll request PostgreSQL to shut down using the `fast` strategy within the overall `.spec.stopDelay` time, which is the `terminationGracePeriodSeconds` of the Pods. Closes #3032 Signed-off-by: Marco Nenciarini <[email protected]> Signed-off-by: Armando Ruocco <[email protected]> Signed-off-by: Gabriele Bartolini <[email protected]> Signed-off-by: Leonardo Cecchi <[email protected]> Co-authored-by: Marco Nenciarini <[email protected]> Co-authored-by: Armando Ruocco <[email protected]> Co-authored-by: Gabriele Bartolini <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch moves the shutdown logic from the lifecycle manager to the instance manager, simplifying its structure.
The
.spec.smartStopDelayfield is used now as the time given to the PostgreSQL smart shutdown sequence. After that, we'll request PostgreSQL to shut down using thefaststrategy..spec.stopDelayis used as grace period of the PostgreSQL Pods.Closes #3032