Repository navigation

chore: rename `smartStopDelay` to `smartShutdownTimeout` - #3030

Merged

gbartolini merged 1 commit into

mainfrom

Oct 10, 2023

Merged

chore: rename `smartStopDelay` to `smartShutdownTimeout`#3030
gbartolini merged 1 commit into
mainfrom
dev/3027

mnencia commented Oct 9, 2023 •

edited

Loading

Member

Rename the newly introduced smartStopDelay parameter (never released)
into a clearer one called smartShutdownTimeout, which exactly describes
the intention of that option: control for how long we wait for PostgreSQL
to execute a graceful shutdown when requested, before trying a fast one
(during shutdown or fencing, for example).

Closes #3027

mnencia requested review from armru, fcanovai, gbartolini, leonardoce, phisco and sxd as code owners

October 9, 2023 15:01

github-actions Bot added backport-requested ◀️ release-1.19 labels

github-actions Bot commented Oct 9, 2023

Contributor

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

github-actions Bot commented Oct 9, 2023

Contributor

❗ By default, the pull request is configured to backport to all release branches.

To stop backporting this pr, remove the label: backport-requested ◀️ or add the label 'do not backport'
To stop backporting this pr to a certain release branch, remove the specific branch label: release-x.y

mnencia force-pushed the dev/3027 branch from d28714d to 91be948 Compare

October 9, 2023 15:02

github-actions Bot commented Oct 9, 2023

Contributor

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

mnencia marked this pull request as draft

October 9, 2023 15:02

armru force-pushed the dev/3027 branch from 91be948 to 80cec86 Compare

October 9, 2023 15:12

github-actions Bot commented Oct 9, 2023

Contributor

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

armru force-pushed the dev/3027 branch from 80cec86 to 0b80a25 Compare

October 9, 2023 15:13

github-actions Bot commented Oct 9, 2023

Contributor

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

mnencia force-pushed the dev/3027 branch from 0b80a25 to cb6adf8 Compare

October 9, 2023 15:17

github-actions Bot commented Oct 9, 2023

Contributor

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

1 similar comment

github-actions Bot commented Oct 9, 2023

Contributor

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

gbartolini approved these changes

View reviewed changes

gbartolini added do not backport and removed release-1.19 labels

github-actions Bot commented Oct 9, 2023

Contributor

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

2 similar comments

github-actions Bot commented Oct 9, 2023

Contributor

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

github-actions Bot commented Oct 9, 2023

Contributor

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

gbartolini changed the title ~~fix: formula to calculate smartShutdownTimeout~~ fix: formula to validate smartStopDelay

github-actions Bot commented Oct 9, 2023

Contributor

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

gbartolini added the ok to merge 👌 label

mnencia commented

View reviewed changes

internal/cmd/manager/instance/run/lifecycle/shutdown.go Resolved

mnencia force-pushed the dev/3027 branch from 42ef675 to 82a03d0 Compare

October 9, 2023 16:00

mnencia marked this pull request as ready for review

October 9, 2023 16:00

mnencia commented Oct 9, 2023

Member Author

/test limit=local

github-actions Bot commented Oct 9, 2023

Contributor

@mnencia, here's the link to the E2E on CNPG workflow run: https://github.com/cloudnative-pg/cloudnative-pg/actions/runs/6459035769

leonardoce added the do not merge 🙅 label

gbartolini removed ok to merge 👌 backport-requested ◀️ do not backport labels

leonardoce force-pushed the dev/3027 branch from 3ef1534 to 5cef43d Compare

October 9, 2023 16:48

gbartolini commented Oct 9, 2023

Contributor

We have decided to first refactor the code and complete work related to #3032

gbartolini commented Oct 9, 2023

Contributor

/test limit=local

github-actions Bot commented Oct 9, 2023

Contributor

@gbartolini, here's the link to the E2E on CNPG workflow run: https://github.com/cloudnative-pg/cloudnative-pg/actions/runs/6461236051

litaocdl force-pushed the dev/3027 branch 3 times, most recently from f0b14eb to e54bd2b Compare

October 10, 2023 09:15

litaocdl commented Oct 10, 2023

Collaborator

after solve conflict, only doc changes, will going to merge

mnencia force-pushed the dev/3027 branch from e54bd2b to a2e0f48 Compare

October 10, 2023 09:17


          chore: rename smartStopDelay to smartShutdownTimeout

Signed-off-by: Marco Nenciarini <[email protected]>

litaocdl force-pushed the dev/3027 branch from a2e0f48 to 0232623 Compare

October 10, 2023 09:21

mnencia changed the title ~~fix: formula to validate and adjust smartStopDelay~~ chore: rename smartStopDelay to smartShutdownTimeout

gbartolini changed the title ~~chore: rename smartStopDelay to smartShutdownTimeout~~ chore: rename smartStopDelay to smartShutdownTimeout

litaocdl commented Oct 10, 2023

Collaborator

/test limit=local

github-actions Bot commented Oct 10, 2023

Contributor

@litaocdl, here's the link to the E2E on CNPG workflow run: https://github.com/cloudnative-pg/cloudnative-pg/actions/runs/6467389891

gbartolini approved these changes

View reviewed changes

leonardoce approved these changes

View reviewed changes

gbartolini merged commit 1a7c3b9 into main

gbartolini deleted the dev/3027 branch

October 10, 2023 09:36

gbartolini mentioned this pull request

primary failure and timeline change can lead to replica failure which is not respected correctly #2800

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do not merge 🙅