Repository navigation
Conversation
gbartolini
requested review from
armru,
fcanovai,
leonardoce,
mnencia,
phisco and
sxd
as code owners
September 27, 2023 08:56
Contributor
|
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
github-actions
Bot
added
backport-requested ◀️
Contributor
|
❗ By default, the pull request is configured to backport to all release branches.
|
mnencia
approved these changes
Sep 27, 2023
Member
There was a problem hiding this comment.
Suggested change
| `VolumeSnapshotContent` object do not keep all the information regarding the | |
| `VolumeSnapshotContent` object does not keep all the information regarding the |
Contributor
There was a problem hiding this comment.
IMO the better fix is "VolumeSnapshotContent objectS do... " as the plural is used later on.
Contributor
|
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
1 similar comment
Contributor
|
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
jsilvela
approved these changes
Sep 27, 2023
Closes #2881 Signed-off-by: Gabriele Bartolini <[email protected]>
Co-authored-by: Marco Nenciarini <[email protected]> Signed-off-by: Jaime Silvela <[email protected]>
Signed-off-by: Jaime Silvela <[email protected]>
Contributor
|
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
Contributor
|
/ok-to-merge |
Contributor
|
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
Signed-off-by: Jaime Silvela <[email protected]>
gbartolini
added
do not backport
Lennart01
pushed a commit
to Lennart01/cloudnative-pg
that referenced
this pull request
Sep 30, 2023
Adds explanations of the persistence controls for volume snapshots and volume snapshot contents. Closes cloudnative-pg#2881 Signed-off-by: Gabriele Bartolini <[email protected]> Signed-off-by: Jaime Silvela <[email protected]> Co-authored-by: Jaime Silvela <[email protected]> Co-authored-by: Marco Nenciarini <[email protected]> Signed-off-by: Lennart Krauch <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2881