Skip to content

chore: enforce standard_conforming_strings in metric collection - #2888

Merged
sxd merged 1 commit into
mainfrom
dev/2887
Sep 27, 2023
Merged

sxd merged 1 commit into
mainfrom
dev/2887

Conversation

@gbartolini

@gbartolini gbartolini commented Sep 26, 2023 •

Copy link
Copy Markdown
Contributor

Ensure that standard_conforming_strings is set to on in every Prometheus connection transaction for metric collection. This is just in case users disable that globally.

Closes #2887

@github-actions github-actions Bot added backport-requested ◀️ This pull request should be backported to all supported releases release-1.19 labels Sep 26, 2023
@github-actions

Copy link
Copy Markdown
Contributor

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@github-actions

Copy link
Copy Markdown
Contributor

❗ By default, the pull request is configured to backport to all release branches.

  • To stop backporting this pr, remove the label: backport-requested ◀️ or add the label 'do not backport'
  • To stop backporting this pr to a certain release branch, remove the specific branch label: release-x.y

@github-actions

Copy link
Copy Markdown
Contributor

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@github-actions

Copy link
Copy Markdown
Contributor

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@github-actions

Copy link
Copy Markdown
Contributor

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

Ensure that `standard_conforming_strings` is set to `on` in
every Prometheus connection transaction for metric collection.
This is just in case users disable that globally.

Closes #2887

Signed-off-by: Gabriele Bartolini <[email protected]>
@sxd sxd added the ok to merge 👌 This PR can be merged label Sep 27, 2023
@sxd
sxd merged commit 529185e into main Sep 27, 2023
@sxd
sxd deleted the dev/2887 branch September 27, 2023 13:56
cnpg-bot pushed a commit that referenced this pull request Sep 27, 2023
)

Ensure that `standard_conforming_strings` is set to `on` in every
Prometheus connection transaction for metric collection. This is just in
case users disable that globally.

Closes #2887

Signed-off-by: Gabriele Bartolini <[email protected]>
(cherry picked from commit 529185e)
cnpg-bot pushed a commit that referenced this pull request Sep 27, 2023
)

Ensure that `standard_conforming_strings` is set to `on` in every
Prometheus connection transaction for metric collection. This is just in
case users disable that globally.

Closes #2887

Signed-off-by: Gabriele Bartolini <[email protected]>
(cherry picked from commit 529185e)
Lennart01 pushed a commit to Lennart01/cloudnative-pg that referenced this pull request Sep 30, 2023
…oudnative-pg#2888)

Ensure that `standard_conforming_strings` is set to `on` in every
Prometheus connection transaction for metric collection. This is just in
case users disable that globally.

Closes cloudnative-pg#2887

Signed-off-by: Gabriele Bartolini <[email protected]>
Signed-off-by: Lennart Krauch <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-requested ◀️ This pull request should be backported to all supported releases ok to merge 👌 This PR can be merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Ensure standard_conforming_strings is set to on in Prometheus connections

4 participants