Skip to content

fix: ensure that restore snapshot cmd omits excluded files - #2879

Merged
gbartolini merged 3 commits into
mainfrom
dev/2865
Sep 28, 2023
Merged

gbartolini merged 3 commits into
mainfrom
dev/2865

Conversation

@armru

@armru armru commented Sep 26, 2023 •

Copy link
Copy Markdown
Member

After the recovery process from a volume snapshot completes,
we need to cleanup the content of PGDATA, similarly to what
backup tools like Barman do. This is the list of files that we
remove from PGDATA:

  • core.*
  • pgsql_tmp*
  • postgresql.auto.conf.tmp
  • current_logfiles.tmp
  • pg_internal.init
  • postmaster.pid
  • postmaster.opts
  • recovery.conf
  • recovery.signal
  • standby.signal
  • log/*
  • pg_dynshmem/*
  • pg_log/*
  • pg_notify/*
  • pg_replslot/*
  • pg_serial/*
  • pg_snapshots/*
  • pg_stat_tmp/*
  • pg_subtrans/*

Closes #2865

@github-actions github-actions Bot added backport-requested ◀️ This pull request should be backported to all supported releases release-1.19 labels Sep 26, 2023
@github-actions

Copy link
Copy Markdown
Contributor

❗ By default, the pull request is configured to backport to all release branches.

  • To stop backporting this pr, remove the label: backport-requested ◀️ or add the label 'do not backport'
  • To stop backporting this pr to a certain release branch, remove the specific branch label: release-x.y

@armru

armru commented Sep 26, 2023

Copy link
Copy Markdown
Member Author

/test limit=local

@github-actions

Copy link
Copy Markdown
Contributor

@armru armru changed the title fix: ensure that restore snapshot cmd doesn't include excluded files fix: ensure that restore snapshot cmd omits excluded files Sep 26, 2023
@gbartolini gbartolini added do not backport This PR must not be backported - it will be in the next minor release and removed backport-requested ◀️ This pull request should be backported to all supported releases release-1.19 labels Sep 26, 2023
@leonardoce

Copy link
Copy Markdown
Contributor

/ok-to-merge

@cnpg-bot cnpg-bot added the ok to merge 👌 This PR can be merged label Sep 26, 2023
@leonardoce

Copy link
Copy Markdown
Contributor

The E2e were canceled, I ran them on the EnterpriseDB repo

armru and others added 3 commits September 28, 2023 10:06
Signed-off-by: Gabriele Bartolini <[email protected]>
Signed-off-by: Leonardo Cecchi <[email protected]>
@gbartolini
gbartolini deleted the dev/2865 branch September 28, 2023 08:06
Lennart01 pushed a commit to Lennart01/cloudnative-pg that referenced this pull request Sep 30, 2023
…ve-pg#2879)

After the recovery process from a volume snapshot completes,
we need to cleanup the content of PGDATA, similarly to what
backup tools like Barman do. This is the list of files that we
remove from PGDATA:

- core.*
- pgsql_tmp*
- postgresql.auto.conf.tmp
- current_logfiles.tmp
- pg_internal.init
- postmaster.pid
- postmaster.opts
- recovery.conf
- recovery.signal
- standby.signal
- log/*
- pg_dynshmem/*
- pg_log/*
- pg_notify/*
- pg_replslot/*
- pg_serial/*
- pg_snapshots/*
- pg_stat_tmp/*
- pg_subtrans/*

Closes cloudnative-pg#2865

Signed-off-by: Armando Ruocco <[email protected]>
Signed-off-by: Gabriele Bartolini <[email protected]>
Signed-off-by: Leonardo Cecchi <[email protected]>
Co-authored-by: Gabriele Bartolini <[email protected]>
Co-authored-by: Leonardo Cecchi <[email protected]>
Signed-off-by: Lennart Krauch <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do not backport This PR must not be backported - it will be in the next minor release ok to merge 👌 This PR can be merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cleanup content of PGDATA after recovery from snapshots

4 participants