Repository navigation
fix: cleans up the resources lists in the generated Role - #2875
Merged
Merged
Conversation
YanniHu1996
requested review from
armru,
fcanovai,
gbartolini,
leonardoce,
mnencia,
phisco and
sxd
as code owners
September 26, 2023 06:38
github-actions
Bot
added
backport-requested ◀️
Contributor
|
❗ By default, the pull request is configured to backport to all release branches.
|
YanniHu1996
force-pushed
the
dev/cnp-4161
branch
from
September 26, 2023 07:12
6cd20b9 to
a2a6d12
Compare
leonardoce
force-pushed
the
dev/cnp-4161
branch
from
September 26, 2023 10:30
a2a6d12 to
c20d0a8
Compare
leonardoce
changed the title
Contributor
|
/test |
Contributor
|
@leonardoce, here's the link to the E2E on CNPG workflow run: https://github.com/cloudnative-pg/cloudnative-pg/actions/runs/6311434406 |
leonardoce
approved these changes
Sep 26, 2023
Signed-off-by: YanniHu1996 <[email protected]>
Signed-off-by: Leonardo Cecchi <[email protected]>
Signed-off-by: Armando Ruocco <[email protected]>
armru
approved these changes
Sep 26, 2023
Member
|
/ok-to-merge |
cnpg-bot
pushed a commit
that referenced
this pull request
Sep 26, 2023
…tency (#2875) Addresses two inconsistencies in the `ResourceName` sections of the generated roles: - Ensures entries are sorted, preventing items from appearing out of order. - Removes empty items This is achieved using a new utility function, `cleanupResourceList`. Signed-off-by: YanniHu1996 <[email protected]> Signed-off-by: Leonardo Cecchi <[email protected]> Signed-off-by: Armando Ruocco <[email protected]> Co-authored-by: Leonardo Cecchi <[email protected]> Co-authored-by: Armando Ruocco <[email protected]> (cherry picked from commit 03eacc3)
sxd
pushed a commit
that referenced
this pull request
Sep 26, 2023
…tency (#2875) Addresses two inconsistencies in the `ResourceName` sections of the generated roles: - Ensures entries are sorted, preventing items from appearing out of order. - Removes empty items This is achieved using a new utility function, `cleanupResourceList`. Signed-off-by: YanniHu1996 <[email protected]> Signed-off-by: Leonardo Cecchi <[email protected]> Signed-off-by: Armando Ruocco <[email protected]> Co-authored-by: Leonardo Cecchi <[email protected]> Co-authored-by: Armando Ruocco <[email protected]>
Lennart01
pushed a commit
to Lennart01/cloudnative-pg
that referenced
this pull request
Sep 30, 2023
…tency (cloudnative-pg#2875) Addresses two inconsistencies in the `ResourceName` sections of the generated roles: - Ensures entries are sorted, preventing items from appearing out of order. - Removes empty items This is achieved using a new utility function, `cleanupResourceList`. Signed-off-by: YanniHu1996 <[email protected]> Signed-off-by: Leonardo Cecchi <[email protected]> Signed-off-by: Armando Ruocco <[email protected]> Co-authored-by: Leonardo Cecchi <[email protected]> Co-authored-by: Armando Ruocco <[email protected]> Signed-off-by: Lennart Krauch <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #2861
The empty string mentioned by #2861 comes from LADP secret name, refer to https://github.com/cloudnative-pg/cloudnative-pg/blob/main/api/v1/cluster_types.go#L2220-L2227.