Repository navigation
tests: ensure client certificate is always being created - #2870
Merged
Merged
Conversation
sxd
requested review from
armru,
fcanovai,
gbartolini,
leonardoce,
mnencia and
phisco
as code owners
September 25, 2023 21:02
github-actions
Bot
added
backport-requested ◀️
Contributor
|
❗ By default, the pull request is configured to backport to all release branches.
|
Contributor
|
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
The connectivity test were failing due to a dependency of a previous test that should create the proper secret with the required certificate. Now, we create the certificate everytime in the test to keep the tests independent. Signed-off-by: Jonathan Gonzalez V <[email protected]>
sxd
force-pushed
the
dev/fix_connectivity_e2e
branch
from
September 25, 2023 21:33
61dd1d2 to
4470ab6
Compare
Contributor
|
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
YanniHu1996
approved these changes
Sep 26, 2023
phisco
approved these changes
Sep 26, 2023
Contributor
|
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
NiccoloFei
force-pushed
the
dev/fix_connectivity_e2e
branch
from
September 26, 2023 13:11
1e3052d to
369b204
Compare
Signed-off-by: Niccolò Fei <[email protected]>
NiccoloFei
force-pushed
the
dev/fix_connectivity_e2e
branch
from
September 26, 2023 13:12
369b204 to
247bef0
Compare
NiccoloFei
approved these changes
Sep 26, 2023
NiccoloFei
changed the title
Contributor
Author
|
/ok-to-merge |
cnpg-bot
pushed a commit
that referenced
this pull request
Sep 26, 2023
The connectivity test were failing due to a dependency of a previous test that should create the proper secret with the required certificate. Now, we create the certificate every time in the test to keep the tests independent. Signed-off-by: Jonathan Gonzalez V <[email protected]> Signed-off-by: Niccolò Fei <[email protected]> Co-authored-by: Niccolò Fei <[email protected]> (cherry picked from commit 7125b96)
cnpg-bot
pushed a commit
that referenced
this pull request
Sep 26, 2023
The connectivity test were failing due to a dependency of a previous test that should create the proper secret with the required certificate. Now, we create the certificate every time in the test to keep the tests independent. Signed-off-by: Jonathan Gonzalez V <[email protected]> Signed-off-by: Niccolò Fei <[email protected]> Co-authored-by: Niccolò Fei <[email protected]> (cherry picked from commit 7125b96)
Lennart01
pushed a commit
to Lennart01/cloudnative-pg
that referenced
this pull request
Sep 30, 2023
…-pg#2870) The connectivity test were failing due to a dependency of a previous test that should create the proper secret with the required certificate. Now, we create the certificate every time in the test to keep the tests independent. Signed-off-by: Jonathan Gonzalez V <[email protected]> Signed-off-by: Niccolò Fei <[email protected]> Co-authored-by: Niccolò Fei <[email protected]> Signed-off-by: Lennart Krauch <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The connectivity test were failing due to a dependency of a previous test that should create the proper secret with the required certificate. Now, we create the certificate everytime in the test to keep the tests independent.